From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47481)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S9aKt-000152-LK
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 07:01:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S9aKr-00025u-K5
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 07:01:11 -0400
Received: from cantor2.suse.de ([195.135.220.15]:38911 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S9aKr-00025i-Dp
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 07:01:09 -0400
Message-ID: <4F6711F3.5000503@suse.de>
Date: Mon, 19 Mar 2012 12:01:07 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1331492067-32266-1-git-send-email-rth@twiddle.net>
	<4F64E657.1070800@twiddle.net>
In-Reply-To: <4F64E657.1070800@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with
	round-to-nearest.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org

Am 17.03.2012 20:30, schrieb Richard Henderson:
> Ping.

This is linux-user, so cc'ing Riku.

Code looks sane at first sight although I have no clue of the constants'
meaning and effect. ;)

Commit message doesn't mention it but I guess this fixes some bug? How
does it round before the patch?

Andreas

>=20
> On 03/11/2012 11:54 AM, Richard Henderson wrote:
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>>  target-alpha/translate.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
>> index 1d2142b..fe78630 100644
>> --- a/target-alpha/translate.c
>> +++ b/target-alpha/translate.c
>> @@ -3513,7 +3513,8 @@ CPUAlphaState * cpu_alpha_init (const char *cpu_=
model)
>>  #if defined (CONFIG_USER_ONLY)
>>      env->ps =3D PS_USER_MODE;
>>      cpu_alpha_store_fpcr(env, (FPCR_INVD | FPCR_DZED | FPCR_OVFD
>> -                               | FPCR_UNFD | FPCR_INED | FPCR_DNOD));
>> +                               | FPCR_UNFD | FPCR_INED | FPCR_DNOD
>> +                               | FPCR_DYN_NORMAL));
>>  #endif
>>      env->lock_addr =3D -1;
>>      env->fen =3D 1;

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg