From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52941)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S9bEC-0004U7-7y
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 07:58:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S9bEA-0003NP-Iw
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 07:58:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13975)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S9bEA-0003NJ-B7
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 07:58:18 -0400
Message-ID: <4F671F55.4050004@redhat.com>
Date: Mon, 19 Mar 2012 13:58:13 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Xtensa misuse of tb_invalidate_phys_page_range()?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>

void HELPER(wsr_ibreaka)(uint32_t i, uint32_t v)
{
    if (env->sregs[IBREAKENABLE] & (1 << i) && env->sregs[IBREAKA + i]
!= v) {
        tb_invalidate_phys_page_range(
                env->sregs[IBREAKA + i], env->sregs[IBREAKA + i] + 1, 0);
        tb_invalidate_phys_page_range(v, v + 1, 0);
    }
    env->sregs[IBREAKA + i] = v;
}

tb_invalidate_phys_page_range() expects a virtual address in user mode,
and a ram_addr_t in system mode.  I'm guessing that v is a virtual address?

This needs to be fixed for system mode if so (and in any case - even if
it's a physical address, it needs to be translated to a ram_addr_t).

Similar issue for hw/kvmvapic.c.

-- 
error compiling committee.c: too many arguments to function