From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9bwV-0003mo-Jb for qemu-devel@nongnu.org; Mon, 19 Mar 2012 08:44:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9bwP-0003kw-2Q for qemu-devel@nongnu.org; Mon, 19 Mar 2012 08:44:07 -0400 Message-ID: <4F672A0E.2090301@suse.de> Date: Mon, 19 Mar 2012 13:43:58 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1331985651-16227-1-git-send-email-sw@weilnetz.de> <4F670B62.2040606@suse.de> <4F672711.7030501@weilnetz.de> In-Reply-To: <4F672711.7030501@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-mips: Remove unused inline function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial , Stefan Hajnoczi , qemu-devel@nongnu.org, Aurelien Jarno Am 19.03.2012 13:31, schrieb Stefan Weil: > Am 19.03.2012 13:17, schrieb Stefan Hajnoczi: >> On Mon, Mar 19, 2012 at 10:33 AM, Andreas F=E4rber >> wrote: >>> Am 17.03.2012 13:00, schrieb Stefan Weil: >>>> Function set_HILO is not needed anywhere. >>> >>> Does this cause any warnings? Given the state mips is currently in (T= CG >>> patches queuing), I'd suggest to hold this off for a bit, but I don't >>> really mind either way. >>> >>> Commit message does not mention if this was never used in the first >>> place or became unused during TCG conversion or some other refactorin= g? >> >> It doesn't cause any warning on my build here, so there's no strict >> need for this patch. >> >> I have dropped the patch for now. Please resend if you want to get it >> in and address Andreas' questions. >=20 > the function was never used. It should be removed just to keep > the code clean and free of unneeded functions. I noticed this > function when I looked after the functions which follow > (set_HIT0_LO, ...). Those functions are very similar, so I > think set_HILO was the copy master for those functions > (maybe used in a local code version whic was never committed). Could you please check that it is not used by Richard Sandiford's, Khansa Butt's and Jia Liu's patches? Then I'll happily ack. >=20 > Static inline functions never create a gcc warning when they > are unused, as far as I know. Maybe other tools like static code > analysers raise a warning. Sure, I was thinking of the static analysis tools you occasionally posted patches for. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg