From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9c28-0005VI-NQ for qemu-devel@nongnu.org; Mon, 19 Mar 2012 08:50:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9c1u-0004ac-IW for qemu-devel@nongnu.org; Mon, 19 Mar 2012 08:49:56 -0400 Received: from mout.web.de ([212.227.15.3]:58939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9c1u-0004aL-9M for qemu-devel@nongnu.org; Mon, 19 Mar 2012 08:49:42 -0400 Message-ID: <4F672B62.1020105@web.de> Date: Mon, 19 Mar 2012 13:49:38 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <541C8B7E-1E25-479E-B69E-A4B58BFA45F3@nowonline.co.uk> <4F672958.6080609@weilnetz.de> In-Reply-To: <4F672958.6080609@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Lee Essen , Stefan Hajnoczi , qemu-devel@nongnu.org Am 19.03.2012 13:40, schrieb Stefan Weil: > Am 19.03.2012 13:05, schrieb Lee Essen: >> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: >> >>> On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen >>> wrote: >>>> Signed-off-by: Lee Essen >>>> >>>> --- >>>> >>>> scripts/tracetool | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> I'm going to spend some time today reviewing recent tracing patches. >>> I'd prefer to move to a Python version of tracetool rather than worry >>> about the shell quirks across all host platforms. >>> >>> If the Python rewrite cannot be merged for 1.1 then it makes sense to >>> go with shell portability fix. >> >> Hi Stefan, >> >> While you are looking at this, there are a couple of other related >> issues worth having in the back of your mind: >> >> 1. "self" is a reserved word in Solaris/Illumos trace, and it's used >> in a few trace calls. >> 2. "bool" isn't recognised by default, again used in a couple of >> traces ... could be fixed by typedef, but switching to int is >> probably better (imho) > > No. The correct solution is including stdbool.h which is provided by the > compiler (gcc) and which defines bool and its values false and true. AFAIU the issue is not with C code but with D code: http://docs.oracle.com/cd/E19253-01/817-6223/chp-typeopexpr-2/index.html Andreas > > > More boolean variables should use bool instead of int, because that > improves > readability of the code and saves memory in structures. > > Regards, > Stefan W. >