* [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest.
@ 2012-03-11 18:54 Richard Henderson
2012-03-17 19:30 ` Richard Henderson
0 siblings, 1 reply; 4+ messages in thread
From: Richard Henderson @ 2012-03-11 18:54 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
target-alpha/translate.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/target-alpha/translate.c b/target-alpha/translate.c
index 1d2142b..fe78630 100644
--- a/target-alpha/translate.c
+++ b/target-alpha/translate.c
@@ -3513,7 +3513,8 @@ CPUAlphaState * cpu_alpha_init (const char *cpu_model)
#if defined (CONFIG_USER_ONLY)
env->ps = PS_USER_MODE;
cpu_alpha_store_fpcr(env, (FPCR_INVD | FPCR_DZED | FPCR_OVFD
- | FPCR_UNFD | FPCR_INED | FPCR_DNOD));
+ | FPCR_UNFD | FPCR_INED | FPCR_DNOD
+ | FPCR_DYN_NORMAL));
#endif
env->lock_addr = -1;
env->fen = 1;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest.
2012-03-11 18:54 [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest Richard Henderson
@ 2012-03-17 19:30 ` Richard Henderson
2012-03-19 11:01 ` Andreas Färber
0 siblings, 1 reply; 4+ messages in thread
From: Richard Henderson @ 2012-03-17 19:30 UTC (permalink / raw)
To: qemu-devel
Ping.
On 03/11/2012 11:54 AM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> target-alpha/translate.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
> index 1d2142b..fe78630 100644
> --- a/target-alpha/translate.c
> +++ b/target-alpha/translate.c
> @@ -3513,7 +3513,8 @@ CPUAlphaState * cpu_alpha_init (const char *cpu_model)
> #if defined (CONFIG_USER_ONLY)
> env->ps = PS_USER_MODE;
> cpu_alpha_store_fpcr(env, (FPCR_INVD | FPCR_DZED | FPCR_OVFD
> - | FPCR_UNFD | FPCR_INED | FPCR_DNOD));
> + | FPCR_UNFD | FPCR_INED | FPCR_DNOD
> + | FPCR_DYN_NORMAL));
> #endif
> env->lock_addr = -1;
> env->fen = 1;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest.
2012-03-17 19:30 ` Richard Henderson
@ 2012-03-19 11:01 ` Andreas Färber
2012-03-19 13:32 ` Richard Henderson
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2012-03-19 11:01 UTC (permalink / raw)
To: Richard Henderson; +Cc: Riku Voipio, qemu-devel
Am 17.03.2012 20:30, schrieb Richard Henderson:
> Ping.
This is linux-user, so cc'ing Riku.
Code looks sane at first sight although I have no clue of the constants'
meaning and effect. ;)
Commit message doesn't mention it but I guess this fixes some bug? How
does it round before the patch?
Andreas
>
> On 03/11/2012 11:54 AM, Richard Henderson wrote:
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>> target-alpha/translate.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
>> index 1d2142b..fe78630 100644
>> --- a/target-alpha/translate.c
>> +++ b/target-alpha/translate.c
>> @@ -3513,7 +3513,8 @@ CPUAlphaState * cpu_alpha_init (const char *cpu_model)
>> #if defined (CONFIG_USER_ONLY)
>> env->ps = PS_USER_MODE;
>> cpu_alpha_store_fpcr(env, (FPCR_INVD | FPCR_DZED | FPCR_OVFD
>> - | FPCR_UNFD | FPCR_INED | FPCR_DNOD));
>> + | FPCR_UNFD | FPCR_INED | FPCR_DNOD
>> + | FPCR_DYN_NORMAL));
>> #endif
>> env->lock_addr = -1;
>> env->fen = 1;
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest.
2012-03-19 11:01 ` Andreas Färber
@ 2012-03-19 13:32 ` Richard Henderson
0 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2012-03-19 13:32 UTC (permalink / raw)
To: Andreas Färber; +Cc: Riku Voipio, qemu-devel
On 03/19/12 04:01, Andreas Färber wrote:
> Am 17.03.2012 20:30, schrieb Richard Henderson:
>> Ping.
>
> This is linux-user, so cc'ing Riku.
>
> Code looks sane at first sight although I have no clue of the constants'
> meaning and effect. ;)
>
> Commit message doesn't mention it but I guess this fixes some bug? How
> does it round before the patch?
It does round-to-zero before the patch.
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-19 13:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-11 18:54 [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest Richard Henderson
2012-03-17 19:30 ` Richard Henderson
2012-03-19 11:01 ` Andreas Färber
2012-03-19 13:32 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).