From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S9eHw-0007qH-Ta
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:14:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S9eHc-0001B1-NR
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:14:24 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:59198)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S9eHc-0001Ak-Jn
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:14:04 -0400
Received: by ggnj2 with SMTP id j2so6395995ggn.4
	for <qemu-devel@nongnu.org>; Mon, 19 Mar 2012 08:14:03 -0700 (PDT)
Message-ID: <4F674D37.7050809@codemonkey.ws>
Date: Mon, 19 Mar 2012 10:13:59 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1332168446-9322-1-git-send-email-ehabkost@redhat.com>
	<1332168446-9322-4-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1332168446-9322-4-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] configure: make full config dir path
 configurable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 03/19/2012 09:47 AM, Eduardo Habkost wrote:
> Instead of hardcoding $sysconfdir/qemu, let the user choose the full
> path.
>
> Signed-off-by: Eduardo Habkost<ehabkost@redhat.com>
> ---
>   configure |   15 ++++++++++-----
>   1 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 8b4e3c1..98027c1 100755
> --- a/configure
> +++ b/configure
> @@ -162,6 +162,7 @@ libdir="\${prefix}/lib"
>   includedir="\${prefix}/include"
>   sysconfdir="\${prefix}/etc"
>   confsuffix="/qemu"
> +fullconfdir=""
>   slirp="yes"
>   fmod_lib=""
>   fmod_inc=""
> @@ -595,6 +596,8 @@ for opt do
>     ;;
>     --sysconfdir=*) sysconfdir="$optarg"
>     ;;
> +  --confdir=*) fullconfdir="$optarg"
> +  ;;
>     --sbindir=*|--libexecdir=*|--sharedstatedir=*|--localstatedir=*|\
>     --oldincludedir=*|--datarootdir=*|--infodir=*|--localedir=*|\
>     --htmldir=*|--dvidir=*|--pdfdir=*|--psdir=*)
> @@ -1010,7 +1013,8 @@ echo "  --mandir=PATH            install man pages in PATH"
>   echo "  --datadir=PATH           install firmware in PATH"
>   echo "  --docdir=PATH            install documentation in PATH"
>   echo "  --bindir=PATH            install binaries in PATH"
> -echo "  --sysconfdir=PATH        install config in PATH/qemu"
> +echo "  --sysconfdir=PATH        install config in PATH$confsuffix"
> +echo "  --confdir=PATH           install config in PATH (overrides --sysconfdir)"

These semantics seem odd to me, is this similar to what autotools does?  I think 
that's what we're trying to match here.

Regards,

Anthony Liguori