From: Anthony Liguori <anthony@codemonkey.ws>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] add --confdir option to configure
Date: Mon, 19 Mar 2012 10:34:06 -0500 [thread overview]
Message-ID: <4F6751EE.2090001@codemonkey.ws> (raw)
In-Reply-To: <20120319153140.GD9375@otherpad.lan.raisama.net>
On 03/19/2012 10:31 AM, Eduardo Habkost wrote:
> On Mon, Mar 19, 2012 at 10:14:54AM -0500, Anthony Liguori wrote:
>> On 03/19/2012 09:47 AM, Eduardo Habkost wrote:
>>> This series change the Makefile to use $(confdir) instead of
>>> $(sysconfdir)/qemu, and allows the full config path configurable instead of
>>> forcing the use of $(sysconfdir)/qemu.
>>
>> What's the use case here? Is this to allow $(sysconfdir)/qemu-kvm?
>
> Yes. On RHEL we usually package qemu-kvm only, but we try to avoid
> conflicts in case other flavors of qemu be provided by third-parties
> (read: EPEL).
>
>>
>> I'd rather we use a PACKAGE_NAME define to do that and have qemu-kvm
>> change PACKAGE_NAME.
>
> I tried to mimic --mandir, --datadir, --docdir, and all other options
> that expect full paths instead of trying to building one itself.
>
> A --package-name option could be provided to make it easier to override
> all the defaults at the same time, but I don't see why not include an
> option to define the full path for confdir, just like we allow for
> datadir, docdir, and mandir.
No, I'm not suggesting --package-name, I'm suggesting that qemu-kvm would carry
a patch to configure that changed a fixed PACKAGE_NAME define.
Regards,
Anthony Liguori
>
next prev parent reply other threads:[~2012-03-19 15:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 14:47 [Qemu-devel] [PATCH 0/3] add --confdir option to configure Eduardo Habkost
2012-03-19 14:47 ` [Qemu-devel] [PATCH 1/3] Makefile: use $(confdir) instead of hardcoding $(sysconfdir)/qemu Eduardo Habkost
2012-03-19 14:47 ` [Qemu-devel] [PATCH 2/3] qemu-options.hx: refer to confdir instead of sysconfdir on docs Eduardo Habkost
2012-03-19 14:47 ` [Qemu-devel] [PATCH 3/3] configure: make full config dir path configurable Eduardo Habkost
2012-03-19 15:13 ` Anthony Liguori
2012-03-19 15:40 ` Paolo Bonzini
2012-03-19 15:14 ` [Qemu-devel] [PATCH 0/3] add --confdir option to configure Anthony Liguori
2012-03-19 15:31 ` Eduardo Habkost
2012-03-19 15:34 ` Anthony Liguori [this message]
2012-03-19 15:43 ` Eduardo Habkost
2012-03-19 15:59 ` Anthony Liguori
2012-03-19 16:09 ` Eduardo Habkost
2012-03-19 16:03 ` Eric Blake
2012-03-19 16:25 ` Anthony Liguori
2012-03-19 16:13 ` Paolo Bonzini
2012-03-19 16:20 ` Eduardo Habkost
2012-03-19 16:22 ` Anthony Liguori
2012-03-19 16:50 ` Eduardo Habkost
2012-03-19 16:31 ` Paolo Bonzini
2012-03-19 17:02 ` Eduardo Habkost
2012-03-19 16:32 ` Anthony Liguori
2012-03-19 16:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6751EE.2090001@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).