From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9ebW-0007QH-79 for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:34:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9eb7-0005xv-NC for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:34:37 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:43015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9eb7-0005xd-Gs for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:34:13 -0400 Received: by dadp14 with SMTP id p14so11175186dad.4 for ; Mon, 19 Mar 2012 08:34:11 -0700 (PDT) Message-ID: <4F6751EE.2090001@codemonkey.ws> Date: Mon, 19 Mar 2012 10:34:06 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332168446-9322-1-git-send-email-ehabkost@redhat.com> <4F674D6E.10708@codemonkey.ws> <20120319153140.GD9375@otherpad.lan.raisama.net> In-Reply-To: <20120319153140.GD9375@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] add --confdir option to configure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org On 03/19/2012 10:31 AM, Eduardo Habkost wrote: > On Mon, Mar 19, 2012 at 10:14:54AM -0500, Anthony Liguori wrote: >> On 03/19/2012 09:47 AM, Eduardo Habkost wrote: >>> This series change the Makefile to use $(confdir) instead of >>> $(sysconfdir)/qemu, and allows the full config path configurable instead of >>> forcing the use of $(sysconfdir)/qemu. >> >> What's the use case here? Is this to allow $(sysconfdir)/qemu-kvm? > > Yes. On RHEL we usually package qemu-kvm only, but we try to avoid > conflicts in case other flavors of qemu be provided by third-parties > (read: EPEL). > >> >> I'd rather we use a PACKAGE_NAME define to do that and have qemu-kvm >> change PACKAGE_NAME. > > I tried to mimic --mandir, --datadir, --docdir, and all other options > that expect full paths instead of trying to building one itself. > > A --package-name option could be provided to make it easier to override > all the defaults at the same time, but I don't see why not include an > option to define the full path for confdir, just like we allow for > datadir, docdir, and mandir. No, I'm not suggesting --package-name, I'm suggesting that qemu-kvm would carry a patch to configure that changed a fixed PACKAGE_NAME define. Regards, Anthony Liguori >