From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9eg5-0002ly-GF for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:39:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9eg0-00078x-2T for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:39:21 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:57413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9efz-00078i-U3 for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:39:15 -0400 Received: by ghrr14 with SMTP id r14so6444592ghr.4 for ; Mon, 19 Mar 2012 08:39:14 -0700 (PDT) Message-ID: <4F67531E.70206@codemonkey.ws> Date: Mon, 19 Mar 2012 10:39:10 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332168883-9961-1-git-send-email-ehabkost@redhat.com> <4F674C63.6080009@codemonkey.ws> <20120319153731.GE9375@otherpad.lan.raisama.net> In-Reply-To: <20120319153731.GE9375@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] -readconfig: accept fd= option (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org On 03/19/2012 10:37 AM, Eduardo Habkost wrote: > On Mon, Mar 19, 2012 at 10:10:27AM -0500, Anthony Liguori wrote: >> On 03/19/2012 09:54 AM, Eduardo Habkost wrote: >>> This is a resubmit of a previous series I sent as a RFC, with some changes to >>> prepare for an upcoming patch that will make additional changes to the default >>> config-file loading code. >>> >>> This series needs be applied on top of the "./configure --confdir" series I >>> sent today. >> >> Why not just use /dev/fd/N ? > > Personally, I don't like filenames with special meanings (as not every > OS has /dev/fd we would have to treat them specially), or filenames that > become non-extensible mini-languages by themselves. Many other > command-line options use the key=value syntax, and some already have an > "fd" option, so this just follows the convention. But you're also breaking compat, which is not something to be done lightly. > > Also, this is more extensible to allow more options to be added to > -readconfig if needed (for example: debugging options, or the > help=defconfig option I added on the RFC series I sent after this one). I'd personally prefer to keep readconfig simple. See the series I sent out as an RFC. Regards, Anthony Liguori >