From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9ezm-0001wm-Sz for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:59:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9ezl-0003MX-0G for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:59:42 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:61309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9ezk-0003MN-Pm for qemu-devel@nongnu.org; Mon, 19 Mar 2012 11:59:40 -0400 Received: by pbcuo5 with SMTP id uo5so1454016pbc.4 for ; Mon, 19 Mar 2012 08:59:38 -0700 (PDT) Message-ID: <4F6757E7.4060609@codemonkey.ws> Date: Mon, 19 Mar 2012 10:59:35 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332168446-9322-1-git-send-email-ehabkost@redhat.com> <4F674D6E.10708@codemonkey.ws> <20120319153140.GD9375@otherpad.lan.raisama.net> <4F6751EE.2090001@codemonkey.ws> <20120319154319.GF9375@otherpad.lan.raisama.net> In-Reply-To: <20120319154319.GF9375@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] add --confdir option to configure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org On 03/19/2012 10:43 AM, Eduardo Habkost wrote: > On Mon, Mar 19, 2012 at 10:34:06AM -0500, Anthony Liguori wrote: >> On 03/19/2012 10:31 AM, Eduardo Habkost wrote: >>> On Mon, Mar 19, 2012 at 10:14:54AM -0500, Anthony Liguori wrote: >>>> On 03/19/2012 09:47 AM, Eduardo Habkost wrote: >>>>> This series change the Makefile to use $(confdir) instead of >>>>> $(sysconfdir)/qemu, and allows the full config path configurable instead of >>>>> forcing the use of $(sysconfdir)/qemu. >>>> >>>> What's the use case here? Is this to allow $(sysconfdir)/qemu-kvm? >>> >>> Yes. On RHEL we usually package qemu-kvm only, but we try to avoid >>> conflicts in case other flavors of qemu be provided by third-parties >>> (read: EPEL). >>> >>>> >>>> I'd rather we use a PACKAGE_NAME define to do that and have qemu-kvm >>>> change PACKAGE_NAME. >>> >>> I tried to mimic --mandir, --datadir, --docdir, and all other options >>> that expect full paths instead of trying to building one itself. >>> >>> A --package-name option could be provided to make it easier to override >>> all the defaults at the same time, but I don't see why not include an >>> option to define the full path for confdir, just like we allow for >>> datadir, docdir, and mandir. >> >> No, I'm not suggesting --package-name, I'm suggesting that qemu-kvm >> would carry a patch to configure that changed a fixed PACKAGE_NAME >> define. > > Are you really suggesting that forcing downstream to carry a patch is > better than having a configure option? To change the package name? Absolutely! > If you suggest making it configurable using a variable on the 'make' > command-line it would be OK, but I kind of hoped that no modern software > project would ever require packagers to use configure-by-sed methods to > set build parameters. Changing the package name is a Big Deal. It's not that we should provide a friendly interface for. If you're already a downstream, I don't see the problem carrying a one liner for something this significant. Regards, Anthony Liguori