From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9fA1-0002zJ-0p for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:10:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9f9s-000672-IJ for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:10:16 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:50628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9f9s-00062H-8T for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:10:08 -0400 Received: by dadp14 with SMTP id p14so11219835dad.4 for ; Mon, 19 Mar 2012 09:10:05 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4F675A55.5080000@redhat.com> Date: Mon, 19 Mar 2012 17:09:57 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1332169763-30665-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1332169763-30665-1-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/9] qemu capabilities reporting and config changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Gerd Hoffman , Eric Blake , qemu-devel@nongnu.org, Eduardo Habkost Il 19/03/2012 16:09, Anthony Liguori ha scritto: > Hi, > > I didn't start out intending to write this series, but I end up here trying to > resolve an issue in the gtk UI. What issue? :) > This series does some dramatic refactoring to -readconfig essentially throwing > away the existing (trivial) implementation and replacing it with glib's > GKeyFile support. Nice. > It also plumbs the existing command line options through QemuOpts via a special > 'system' section. This means that any command line option can be specified via > readconfig and that the combination of -nodefconfig and -writeconfig should give > you exactly the same guest in a repeatable fashion. I don't like this because it turns command-line options into ABI. Also, it puts there some options for which -writeconfig is actually able to produce a QemuOpts equivalent, such as -monitor. I have a few patches here that convert almost every option that matters into QemuOpts so that -writeconfig records it: -m, -bios, -localtime, -S, -M, -smp, -numa, -nodefaults, -no-shutdown, -no-reboot. The only thing that is left basically is -display, where I chickened out. > Finally, this series exposes a new -query-capabilities option which dumps the > QemuOpts schema's via JSON to standard output (along with some other goodies > like the version info and supported QMP commands). > > The purpose of this series is to change the way management tools (esp libvirt) > interact with QEMU to determine capabilities. Instead of help parsing, libvirt > should use -query-capabilities to figure out which options are supported and > when new suboptions are available. > > I would like to push this series into 1.1 I think it's too early. However, we can definitely apply 1/2/7/8/9 now. Paolo