qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Eric Blake <eblake@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] add --confdir option to configure
Date: Mon, 19 Mar 2012 11:25:08 -0500	[thread overview]
Message-ID: <4F675DE4.4070909@codemonkey.ws> (raw)
In-Reply-To: <4F6758ED.7010806@redhat.com>

On 03/19/2012 11:03 AM, Eric Blake wrote:
> On 03/19/2012 09:43 AM, Eduardo Habkost wrote:
>>>> A --package-name option could be provided to make it easier to override
>>>> all the defaults at the same time, but I don't see why not include an
>>>> option to define the full path for confdir, just like we allow for
>>>> datadir, docdir, and mandir.
>>>
>>> No, I'm not suggesting --package-name, I'm suggesting that qemu-kvm
>>> would carry a patch to configure that changed a fixed PACKAGE_NAME
>>> define.
>
> Actually, the idea of an explicit --package-name is not that bad: the
> upstream automake list recently had a discussion on whether it should be
> possible to alter the PACKAGE_NAME at configure or even make time, and
> the conclusion was that it might be a useful idea, but we'd need to
> pursue getting the GNU Coding Standards, autoconf, and automake all
> updated to make it a reality, as it is not necessarily a trivial task
> from the outset.
>
> https://lists.gnu.org/archive/html/automake/2012-02/msg00034.html

That's interesting, thanks for point it out.

But I think for qemu, we should stick to not making PACKAGE_NAME configurable.

I would hope that qemu-kvm would stop being packaged separate from qemu in most 
distributions in the not so distance future.

Regards,

Anthony Liguori

>
>> If you suggest making it configurable using a variable on the 'make'
>> command-line it would be OK, but I kind of hoped that no modern software
>> project would ever require packagers to use configure-by-sed methods to
>> set build parameters.
>
> Obviously, since qemu doesn't use automake, we aren't quite in the same
> position as that automake thread; and even though we are not bound by
> GNU Coding Standards, it might be interesting to see what happens on
> that front, to make sure we are not proposing an incompatible solution.
>

  reply	other threads:[~2012-03-19 16:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 14:47 [Qemu-devel] [PATCH 0/3] add --confdir option to configure Eduardo Habkost
2012-03-19 14:47 ` [Qemu-devel] [PATCH 1/3] Makefile: use $(confdir) instead of hardcoding $(sysconfdir)/qemu Eduardo Habkost
2012-03-19 14:47 ` [Qemu-devel] [PATCH 2/3] qemu-options.hx: refer to confdir instead of sysconfdir on docs Eduardo Habkost
2012-03-19 14:47 ` [Qemu-devel] [PATCH 3/3] configure: make full config dir path configurable Eduardo Habkost
2012-03-19 15:13   ` Anthony Liguori
2012-03-19 15:40     ` Paolo Bonzini
2012-03-19 15:14 ` [Qemu-devel] [PATCH 0/3] add --confdir option to configure Anthony Liguori
2012-03-19 15:31   ` Eduardo Habkost
2012-03-19 15:34     ` Anthony Liguori
2012-03-19 15:43       ` Eduardo Habkost
2012-03-19 15:59         ` Anthony Liguori
2012-03-19 16:09           ` Eduardo Habkost
2012-03-19 16:03         ` Eric Blake
2012-03-19 16:25           ` Anthony Liguori [this message]
2012-03-19 16:13         ` Paolo Bonzini
2012-03-19 16:20           ` Eduardo Habkost
2012-03-19 16:22             ` Anthony Liguori
2012-03-19 16:50               ` Eduardo Habkost
2012-03-19 16:31             ` Paolo Bonzini
2012-03-19 17:02               ` Eduardo Habkost
2012-03-19 16:32             ` Anthony Liguori
2012-03-19 16:34               ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F675DE4.4070909@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).