From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9fOb-0005BQ-H5 for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:25:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9fOT-0000q2-IV for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:25:21 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:36886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9fOT-0000po-Cf for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:25:13 -0400 Received: by dadp14 with SMTP id p14so11238935dad.4 for ; Mon, 19 Mar 2012 09:25:11 -0700 (PDT) Message-ID: <4F675DE4.4070909@codemonkey.ws> Date: Mon, 19 Mar 2012 11:25:08 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332168446-9322-1-git-send-email-ehabkost@redhat.com> <4F674D6E.10708@codemonkey.ws> <20120319153140.GD9375@otherpad.lan.raisama.net> <4F6751EE.2090001@codemonkey.ws> <20120319154319.GF9375@otherpad.lan.raisama.net> <4F6758ED.7010806@redhat.com> In-Reply-To: <4F6758ED.7010806@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] add --confdir option to configure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Eduardo Habkost , qemu-devel@nongnu.org On 03/19/2012 11:03 AM, Eric Blake wrote: > On 03/19/2012 09:43 AM, Eduardo Habkost wrote: >>>> A --package-name option could be provided to make it easier to override >>>> all the defaults at the same time, but I don't see why not include an >>>> option to define the full path for confdir, just like we allow for >>>> datadir, docdir, and mandir. >>> >>> No, I'm not suggesting --package-name, I'm suggesting that qemu-kvm >>> would carry a patch to configure that changed a fixed PACKAGE_NAME >>> define. > > Actually, the idea of an explicit --package-name is not that bad: the > upstream automake list recently had a discussion on whether it should be > possible to alter the PACKAGE_NAME at configure or even make time, and > the conclusion was that it might be a useful idea, but we'd need to > pursue getting the GNU Coding Standards, autoconf, and automake all > updated to make it a reality, as it is not necessarily a trivial task > from the outset. > > https://lists.gnu.org/archive/html/automake/2012-02/msg00034.html That's interesting, thanks for point it out. But I think for qemu, we should stick to not making PACKAGE_NAME configurable. I would hope that qemu-kvm would stop being packaged separate from qemu in most distributions in the not so distance future. Regards, Anthony Liguori > >> If you suggest making it configurable using a variable on the 'make' >> command-line it would be OK, but I kind of hoped that no modern software >> project would ever require packagers to use configure-by-sed methods to >> set build parameters. > > Obviously, since qemu doesn't use automake, we aren't quite in the same > position as that automake thread; and even though we are not bound by > GNU Coding Standards, it might be interesting to see what happens on > that front, to make sure we are not proposing an incompatible solution. >