From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9fps-0001Iu-Su for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:53:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9fpn-0005ll-OC for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:53:32 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:52231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9fpn-0005lc-Jy for qemu-devel@nongnu.org; Mon, 19 Mar 2012 12:53:27 -0400 Received: by yhoo21 with SMTP id o21so6567275yho.4 for ; Mon, 19 Mar 2012 09:53:26 -0700 (PDT) Message-ID: <4F676482.9070302@codemonkey.ws> Date: Mon, 19 Mar 2012 11:53:22 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332169763-30665-1-git-send-email-aliguori@us.ibm.com> <4F675A55.5080000@redhat.com> <4F675F63.7070305@codemonkey.ws> <4F675FEE.7020605@redhat.com> <4F6761CE.1090605@codemonkey.ws> <4F6762B3.6060807@redhat.com> In-Reply-To: <4F6762B3.6060807@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/9] qemu capabilities reporting and config changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Anthony Liguori , Eric Blake , Gerd Hoffman , Eduardo Habkost On 03/19/2012 11:45 AM, Paolo Bonzini wrote: > Il 19/03/2012 17:41, Anthony Liguori ha scritto: >> On 03/19/2012 11:33 AM, Paolo Bonzini wrote: >>> Il 19/03/2012 17:31, Anthony Liguori ha scritto: >>>>>> It also plumbs the existing command line options through QemuOpts via >>>>>> a special >>>>>> 'system' section. This means that any command line option can be >>>>>> specified via >>>>>> readconfig and that the combination of -nodefconfig and -writeconfig >>>>>> should give >>>>>> you exactly the same guest in a repeatable fashion. >>>>> >>>>> I don't like this because it turns command-line options into ABI. >>>> >>>> It's already an ABI, no? >>> >>> Right, sorry. Into configuration file ABI, which is supposed to be the >>> "cleaner" ABI. >> >> Right, the basic premise of this series is "perfect is the enemy of >> good". I think we do ourselves more harm than good trying to come up >> with a clean new interface instead of just cleaning up the bits behind >> what we previously had. > > Yeah,it depends on what you consider good. :) My direction was like > "let's cover 90% of the usecases with a decent syntax"; yours is "let's > cover 100% of the usecases even though the syntax may stink". > > (There's time to convert -display before 1.1, which would make 99%). So if we had 99% with good syntax and 1% with a syntax that stinks, that seems reasonable to me, no? >>>>> Also, it puts there some options for which -writeconfig is actually >>>>> able to produce a QemuOpts equivalent, such as -monitor. >>>> >>>> That may be a bug depending on what your concern is. Can you be more >>>> specific? >>> >>> If you write "-monitor stdio" with your series, do you get one or two >>> monitors in the resulting configuration file? >> >> Two, I now understand what you're saying. Let me look into fixing >> that. This is more about -writeconfig. We need to record the origin of >> a particular QemuOpt and have -writeconfig spit out only things that >> came from -readconfig. > > I think it's simpler than that. Just don't mark as gdef those options > that are backed internally by QemuOpts. That's already done. But given the way the parsing works, gdef and def options are both stored in system's QemuOpts. I can fix that though... Regards, Anthony Liguori > Paolo >