qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PULL] Memory core regression fixes
Date: Mon, 19 Mar 2012 19:15:27 +0200	[thread overview]
Message-ID: <4F6769AF.4090201@redhat.com> (raw)
In-Reply-To: <4F66FF17.90303@redhat.com>

On 03/19/2012 11:40 AM, Avi Kivity wrote:
> The last memory core pull introduced a couple of regressions; here are
> the fixes.
>
> Please pull from:
>
>   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent
>

I've tacked on another patch to this branch, fixing a xen regression:

commit 0a1b357f1555ce410d2d0d5f947b5415587ac4d8
Author: Anthony PERARD <anthony.perard@citrix.com>
Date:   Mon Mar 19 15:54:34 2012 +0000

    exec: fix guest memory access for Xen
   
    In cpu_physical_memory_rw, a change has been introduced and
qemu_get_ram_ptr is
    no longuer called with the ram addr we want to access, but only with the
    section address. This patch fixes this. (All other call to
qemu_get_ram_ptr are
    already called with the right address.)
   
    This patch fixes Xen guest.
   
    Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
    Signed-off-by: Avi Kivity <avi@redhat.com>

diff --git a/exec.c b/exec.c
index a3818ff..265e895 100644
--- a/exec.c
+++ b/exec.c
@@ -3856,8 +3856,8 @@ void cpu_physical_memory_rw(target_phys_addr_t
addr, uint8_t *buf,
                 }
             } else {
                 /* RAM case */
-                ptr = qemu_get_ram_ptr(section->mr->ram_addr)
-                    + section_addr(section, addr);
+                ptr = qemu_get_ram_ptr(section->mr->ram_addr
+                                       + section_addr(section, addr));
                 memcpy(buf, ptr, l);
                 qemu_put_ram_ptr(ptr);
             }

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-03-19 17:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19  9:40 [Qemu-devel] [PULL] Memory core regression fixes Avi Kivity
2012-03-19 17:15 ` Avi Kivity [this message]
2012-03-19 17:18   ` Anthony Liguori
2012-03-19 21:16   ` Anthony Liguori
2012-03-19 18:12 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6769AF.4090201@redhat.com \
    --to=avi@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).