From: Anthony Liguori <anthony@codemonkey.ws>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] QOM: device_del core dumps qemu
Date: Mon, 19 Mar 2012 15:22:34 -0500 [thread overview]
Message-ID: <4F67958A.1060805@codemonkey.ws> (raw)
In-Reply-To: <20120319172027.4b6915dd@doriath.home>
On 03/19/2012 03:20 PM, Luiz Capitulino wrote:
>
> # qemu [..] -netdev type=tap,vhost=on,id=guest0,script=qemu-ifup-switch \
> -device virtio-net-pci,netdev=guest0,id=foo
>
> The on the monitor:
>
> (qemu) device_del foo
> (qemu)
Pretty sure this is fixed by:
commit e5ab1404d014cefe22e9a10fca00d0acf4fe412b
Author: Anthony Liguori <aliguori@us.ibm.com>
Date: Thu Mar 15 11:29:56 2012 -0500
pci: fix double free of romfile property
Which I just pushed earlier today.
Could you confirm that?
Regards,
Anthony Liguori
>
> Bisect says it's caused by commit:
>
> commit dd0ba250ca83ed915ea192ab7539cdbb4e868c14
> Author: Paolo Bonzini<pbonzini@redhat.com>
> Date: Thu Feb 2 13:08:48 2012 +0100
>
> qdev: let QOM free properties
>
> Drop the special free callback. Instead, register a "regular"
> release method in the non-legacy property.
>
> Reviewed-by: Anthony Liguori<aliguori@us.ibm.com>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>
next prev parent reply other threads:[~2012-03-19 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 20:20 [Qemu-devel] QOM: device_del core dumps qemu Luiz Capitulino
2012-03-19 20:22 ` Anthony Liguori [this message]
2012-03-19 20:27 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F67958A.1060805@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).