From: Rafael da Veiga Cabral <verganic@gmail.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] PNG screendump alternative
Date: Mon, 19 Mar 2012 21:57:10 -0300 [thread overview]
Message-ID: <4F67D5E6.1030603@gmail.com> (raw)
In-Reply-To: <20120319175045.597dacef@doriath.home>
On 03/19/2012 05:50 PM, Luiz Capitulino wrote:
> On Sat, 17 Mar 2012 19:45:56 -0300
> Rafael<verganic@gmail.com> wrote:
>
>> Hi,
>>
>> I had already started to work on supporting PNG dump output on
>> screendump when got to know there was another effort to do the same
>> (see Add PNG screendump thread from Daniel P. Berrange). Anyway, I'd
>> like to share my implementation which is a little bit different. It
>> does not use any resource/lib besides libpng and qemu itself and is
>> based on qemu-kvm 0.15.1 ppm_save code.
> There are a few problems with this patch. First, it should be against qemu.git
> and 0.15.1 is a bit of an old release (we're moving towards 1.1).
Ok, it's old but pretty stable component for my unstable project, but as
you've mentioned would be a
good try to use 1.1 version and towards.
>
> Also, I'm not sure that we should completely rely on the file extension,
> maybe we should have an argument for it...
eg.: screendump -<png|tiff|jpeg> filename=path/file ?
and the ppm format as fallback.
>
> Anyway, I recommend you join the efforts for the new screendump command
> along with Marc-Andre and Alon.
Great, by increasing the solution where my proposal fits.
>> I'm using that for a personal project developed at Mandriva which uses
>> QMP directly to communicate with qemu VMs rather than using the
>> libvirt although its usage is considered for the future. There is
>> something more to show but it is just QMP related and soon I'll have
>> it done to share.
>>
>> Comments and suggestions are appreciated.
>>
>> Cheers
>> Rafael Cabral
>>
Comments appreciated, thanks Capitulino.
Rafael Cabral
next prev parent reply other threads:[~2012-03-20 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-17 22:45 [Qemu-devel] [PATCH] PNG screendump alternative Rafael
2012-03-19 20:50 ` Luiz Capitulino
2012-03-20 0:57 ` Rafael da Veiga Cabral [this message]
2012-03-19 21:10 ` Anthony Liguori
2012-03-20 1:11 ` Rafael da Veiga Cabral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F67D5E6.1030603@gmail.com \
--to=verganic@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).