qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Zhi Yong Wu <zwu.kernel@gmail.com>,
	Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests
Date: Tue, 20 Mar 2012 10:58:10 +0100	[thread overview]
Message-ID: <4F6854B2.8000209@redhat.com> (raw)
In-Reply-To: <4F685230.9040209@redhat.com>

Am 20.03.2012 10:47, schrieb Paolo Bonzini:
> Il 20/03/2012 10:40, Zhi Yong Wu ha scritto:
>> HI, Kevin,
>>
>> We hope that I/O throttling can be shipped without known issue in QEMU
>> 1.1, so if you are available, can you give this patch some love?
> 
> I'm sorry to say this, but I think I/O throttling is impossible to save.
>  As it is implemented now, it just cannot work in the presence of
> synchronous I/O, except at the cost of busy waiting with the global
> mutex taken.  See the message from Stefan yesterday.

qemu_aio_flush() is busy waiting with the global mutex taken anyway, so
it doesn't change that much.

Kevin

  reply	other threads:[~2012-03-20  9:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13  1:53 [Qemu-devel] [PATCH] block: add the support to drain throttled requests zwu.kernel
2012-03-20  9:40 ` Zhi Yong Wu
2012-03-20  9:47   ` Paolo Bonzini
2012-03-20  9:58     ` Kevin Wolf [this message]
2012-03-20 11:44       ` Stefan Hajnoczi
2012-03-22 19:07         ` Chris Webb
2012-03-23 10:38           ` Stefan Hajnoczi
2012-03-23 10:43             ` Chris Webb
2012-03-23 10:50               ` Stefan Hajnoczi
2012-03-23 11:02                 ` Richard Davies
2012-03-23 11:32                   ` Stefan Hajnoczi
2012-03-23 16:56                     ` Stefan Hajnoczi
2012-03-26 14:21         ` Stefan Hajnoczi
2012-03-26 14:31           ` Kevin Wolf
2012-03-27  4:29           ` Zhi Yong Wu
2012-03-27  6:52             ` Stefan Hajnoczi
2012-03-20  9:56   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6854B2.8000209@redhat.com \
    --to=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=wuzhy@linux.vnet.ibm.com \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).