* [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
@ 2012-03-18 1:09 Brad Smith
2012-03-20 10:14 ` Michal Privoznik
0 siblings, 1 reply; 12+ messages in thread
From: Brad Smith @ 2012-03-18 1:09 UTC (permalink / raw)
To: Michal Privoznik; +Cc: qemu-devel
Michal,
http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
This broke the build. Un-break the tree.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-18 1:09 [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command Brad Smith
@ 2012-03-20 10:14 ` Michal Privoznik
2012-03-20 13:28 ` Brad Smith
0 siblings, 1 reply; 12+ messages in thread
From: Michal Privoznik @ 2012-03-20 10:14 UTC (permalink / raw)
To: Brad Smith; +Cc: qemu-devel
On 18.03.2012 02:09, Brad Smith wrote:
> Michal,
>
> http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
>
>
> This broke the build. Un-break the tree.
>
Can you please be more specific? It works for me so I don't have a clue
what are you referring to. I mean, what compiler do you use, what errors
are thrown, etc.
Michal
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-20 10:14 ` Michal Privoznik
@ 2012-03-20 13:28 ` Brad Smith
2012-03-25 1:19 ` Brad Smith
0 siblings, 1 reply; 12+ messages in thread
From: Brad Smith @ 2012-03-20 13:28 UTC (permalink / raw)
To: Michal Privoznik; +Cc: qemu-devel
On 20/03/12 6:14 AM, Michal Privoznik wrote:
> On 18.03.2012 02:09, Brad Smith wrote:
>> Michal,
>>
>> http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
>>
>>
>> This broke the build. Un-break the tree.
>>
>
>
> Can you please be more specific? It works for me so I don't have a clue
> what are you referring to. I mean, what compiler do you use, what errors
> are thrown, etc.
>
> Michal
The patch commited is full of Linux specific code.
CC qga/commands-posix.o
In file included from qga/commands-posix.c:29:
/usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside
parameter list
/usr/include/arpa/inet.h:74: warning: its scope is only this definition
or declaration, which is probably not what you want
/usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside
parameter list
qga/commands-posix.c: In function 'bios_supports_mode':
qga/commands-posix.c:587: error: 'environ' undeclared (first use in this
function)
qga/commands-posix.c:587: error: (Each undeclared identifier is reported
only once
qga/commands-posix.c:587: error: for each function it appears in.)
qga/commands-posix.c: In function 'guest_suspend':
qga/commands-posix.c:670: error: 'environ' undeclared (first use in this
function)
qga/commands-posix.c: In function 'qmp_guest_network_get_interfaces':
qga/commands-posix.c:764: error: 'INET_ADDRSTRLEN' undeclared (first use
in this function)
qga/commands-posix.c:765: error: 'INET6_ADDRSTRLEN' undeclared (first
use in this function)
qga/commands-posix.c:789: error: 'SIOCGIFHWADDR' undeclared (first use
in this function)
qga/commands-posix.c:810: error: 'struct ifreq' has no member named
'ifr_hwaddr'
qga/commands-posix.c:832: error: dereferencing pointer to incomplete type
qga/commands-posix.c:846: error: dereferencing pointer to incomplete type
qga/commands-posix.c:854: error: dereferencing pointer to incomplete type
qga/commands-posix.c:868: error: dereferencing pointer to incomplete type
qga/commands-posix.c:765: warning: unused variable 'addr6'
qga/commands-posix.c:764: warning: unused variable 'addr4'
gmake: *** [qga/commands-posix.o] Error 1
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-20 13:28 ` Brad Smith
@ 2012-03-25 1:19 ` Brad Smith
2012-03-25 19:47 ` Michael Roth
2012-03-26 9:28 ` Michal Privoznik
0 siblings, 2 replies; 12+ messages in thread
From: Brad Smith @ 2012-03-25 1:19 UTC (permalink / raw)
To: Michal Privoznik; +Cc: qemu-devel
On 20/03/12 9:28 AM, Brad Smith wrote:
> On 20/03/12 6:14 AM, Michal Privoznik wrote:
>> On 18.03.2012 02:09, Brad Smith wrote:
>>> Michal,
>>>
>>> http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
>>>
>>>
>>>
>>> This broke the build. Un-break the tree.
>>>
>>
>>
>> Can you please be more specific? It works for me so I don't have a clue
>> what are you referring to. I mean, what compiler do you use, what errors
>> are thrown, etc.
>>
>> Michal
>
> The patch commited is full of Linux specific code.
This is *STILL BROKEN*. If you can't get a fix in in a timely manner
then REVERT
the broken commit.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-25 1:19 ` Brad Smith
@ 2012-03-25 19:47 ` Michael Roth
2012-03-26 9:28 ` Michal Privoznik
1 sibling, 0 replies; 12+ messages in thread
From: Michael Roth @ 2012-03-25 19:47 UTC (permalink / raw)
To: Brad Smith; +Cc: Michal Privoznik, qemu-devel
On Sat, Mar 24, 2012 at 09:19:20PM -0400, Brad Smith wrote:
> On 20/03/12 9:28 AM, Brad Smith wrote:
> >On 20/03/12 6:14 AM, Michal Privoznik wrote:
> >>On 18.03.2012 02:09, Brad Smith wrote:
> >>>Michal,
> >>>
> >>>http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
> >>>
> >>>
> >>>
> >>>This broke the build. Un-break the tree.
> >>>
> >>
> >>
> >>Can you please be more specific? It works for me so I don't have a clue
> >>what are you referring to. I mean, what compiler do you use, what errors
> >>are thrown, etc.
> >>
> >>Michal
> >
> >The patch commited is full of Linux specific code.
>
> This is *STILL BROKEN*. If you can't get a fix in in a timely manner
> then REVERT
> the broken commit.
Hi Brad,
Just CC'd you on an updated patch from one that Michal sent out earlier
in the week. Don't have a BSD handy to test with so please give it a whirl
and see if it does the job. If so I'll send a PULL first thing in the morning.
In the meantime you can use --disable-guest-agent to skip the qemu-ga
build.
Sorry for the breakage, I'll work on getting a BSD vm together to test future
PULLs.
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-25 1:19 ` Brad Smith
2012-03-25 19:47 ` Michael Roth
@ 2012-03-26 9:28 ` Michal Privoznik
2012-03-26 14:53 ` Michael Roth
1 sibling, 1 reply; 12+ messages in thread
From: Michal Privoznik @ 2012-03-26 9:28 UTC (permalink / raw)
To: Brad Smith; +Cc: qemu-devel
On 25.03.2012 03:19, Brad Smith wrote:
> On 20/03/12 9:28 AM, Brad Smith wrote:
>> On 20/03/12 6:14 AM, Michal Privoznik wrote:
>>> On 18.03.2012 02:09, Brad Smith wrote:
>>>> Michal,
>>>>
>>>> http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
>>>>
>>>>
>>>>
>>>>
>>>> This broke the build. Un-break the tree.
>>>>
>>>
>>>
>>> Can you please be more specific? It works for me so I don't have a clue
>>> what are you referring to. I mean, what compiler do you use, what errors
>>> are thrown, etc.
>>>
>>> Michal
>>
>> The patch commited is full of Linux specific code.
>
> This is *STILL BROKEN*. If you can't get a fix in in a timely manner
> then REVERT
> the broken commit.
>
Brad,
that's because the fix hasn't been merged yet. If you need fix very
quickly you can apply this patch:
http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg04054.html
Michal
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-26 9:28 ` Michal Privoznik
@ 2012-03-26 14:53 ` Michael Roth
2012-03-26 14:55 ` Anthony Liguori
0 siblings, 1 reply; 12+ messages in thread
From: Michael Roth @ 2012-03-26 14:53 UTC (permalink / raw)
To: Michal Privoznik; +Cc: qemu-devel, Brad Smith
On Mon, Mar 26, 2012 at 11:28:01AM +0200, Michal Privoznik wrote:
> On 25.03.2012 03:19, Brad Smith wrote:
> > On 20/03/12 9:28 AM, Brad Smith wrote:
> >> On 20/03/12 6:14 AM, Michal Privoznik wrote:
> >>> On 18.03.2012 02:09, Brad Smith wrote:
> >>>> Michal,
> >>>>
> >>>> http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> This broke the build. Un-break the tree.
> >>>>
> >>>
> >>>
> >>> Can you please be more specific? It works for me so I don't have a clue
> >>> what are you referring to. I mean, what compiler do you use, what errors
> >>> are thrown, etc.
> >>>
> >>> Michal
> >>
> >> The patch commited is full of Linux specific code.
> >
> > This is *STILL BROKEN*. If you can't get a fix in in a timely manner
> > then REVERT
> > the broken commit.
> >
>
> Brad,
>
> that's because the fix hasn't been merged yet. If you need fix very
> quickly you can apply this patch:
>
> http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg04054.html
That one also requires your previous patch, and misses some things Luiz
caught. This is the latest one, Brad is CC'd:
http://www.mail-archive.com/qemu-devel@nongnu.org/msg104240.html
>
> Michal
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-26 14:53 ` Michael Roth
@ 2012-03-26 14:55 ` Anthony Liguori
2012-03-26 15:15 ` Michael Roth
0 siblings, 1 reply; 12+ messages in thread
From: Anthony Liguori @ 2012-03-26 14:55 UTC (permalink / raw)
To: Michael Roth; +Cc: Michal Privoznik, qemu-devel, Brad Smith
On 03/26/2012 09:53 AM, Michael Roth wrote:
> On Mon, Mar 26, 2012 at 11:28:01AM +0200, Michal Privoznik wrote:
>> On 25.03.2012 03:19, Brad Smith wrote:
>>> On 20/03/12 9:28 AM, Brad Smith wrote:
>>>> On 20/03/12 6:14 AM, Michal Privoznik wrote:
>>>>> On 18.03.2012 02:09, Brad Smith wrote:
>>>>>> Michal,
>>>>>>
>>>>>> http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> This broke the build. Un-break the tree.
>>>>>>
>>>>>
>>>>>
>>>>> Can you please be more specific? It works for me so I don't have a clue
>>>>> what are you referring to. I mean, what compiler do you use, what errors
>>>>> are thrown, etc.
>>>>>
>>>>> Michal
>>>>
>>>> The patch commited is full of Linux specific code.
>>>
>>> This is *STILL BROKEN*. If you can't get a fix in in a timely manner
>>> then REVERT
>>> the broken commit.
>>>
>>
>> Brad,
>>
>> that's because the fix hasn't been merged yet. If you need fix very
>> quickly you can apply this patch:
>>
>> http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg04054.html
>
> That one also requires your previous patch, and misses some things Luiz
> caught. This is the latest one, Brad is CC'd:
>
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg104240.html
Mike,
Can you send a PULL request?
Regards,
Anthony Liguori
>
>>
>> Michal
>>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-26 14:55 ` Anthony Liguori
@ 2012-03-26 15:15 ` Michael Roth
2012-03-26 15:18 ` Anthony Liguori
0 siblings, 1 reply; 12+ messages in thread
From: Michael Roth @ 2012-03-26 15:15 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Michal Privoznik, qemu-devel, Brad Smith
On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote:
> On 03/26/2012 09:53 AM, Michael Roth wrote:
> >On Mon, Mar 26, 2012 at 11:28:01AM +0200, Michal Privoznik wrote:
> >>On 25.03.2012 03:19, Brad Smith wrote:
> >>>On 20/03/12 9:28 AM, Brad Smith wrote:
> >>>>On 20/03/12 6:14 AM, Michal Privoznik wrote:
> >>>>>On 18.03.2012 02:09, Brad Smith wrote:
> >>>>>>Michal,
> >>>>>>
> >>>>>>http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>This broke the build. Un-break the tree.
> >>>>>>
> >>>>>
> >>>>>
> >>>>>Can you please be more specific? It works for me so I don't have a clue
> >>>>>what are you referring to. I mean, what compiler do you use, what errors
> >>>>>are thrown, etc.
> >>>>>
> >>>>>Michal
> >>>>
> >>>>The patch commited is full of Linux specific code.
> >>>
> >>>This is *STILL BROKEN*. If you can't get a fix in in a timely manner
> >>>then REVERT
> >>>the broken commit.
> >>>
> >>
> >>Brad,
> >>
> >>that's because the fix hasn't been merged yet. If you need fix very
> >>quickly you can apply this patch:
> >>
> >>http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg04054.html
> >
> >That one also requires your previous patch, and misses some things Luiz
> >caught. This is the latest one, Brad is CC'd:
> >
> >http://www.mail-archive.com/qemu-devel@nongnu.org/msg104240.html
>
> Mike,
>
> Can you send a PULL request?
Yup, I can't confirm the BSD fix atm though, only that it doesn't break builds
on linux/w32. Send anyway or wait for confirmation?
>
> Regards,
>
> Anthony Liguori
>
> >
> >>
> >>Michal
> >>
> >
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-26 15:15 ` Michael Roth
@ 2012-03-26 15:18 ` Anthony Liguori
2012-03-26 15:20 ` Michal Privoznik
2012-03-26 17:07 ` Blue Swirl
0 siblings, 2 replies; 12+ messages in thread
From: Anthony Liguori @ 2012-03-26 15:18 UTC (permalink / raw)
To: Michael Roth; +Cc: Michal Privoznik, qemu-devel, Brad Smith
On 03/26/2012 10:15 AM, Michael Roth wrote:
> On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote:
>
> Yup, I can't confirm the BSD fix atm though, only that it doesn't break builds
> on linux/w32. Send anyway or wait for confirmation?
Brad/Michal,
Can you confirm the fix?
Regards,
Anthony Liguori
>
>>
>> Regards,
>>
>> Anthony Liguori
>>
>>>
>>>>
>>>> Michal
>>>>
>>>
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-26 15:18 ` Anthony Liguori
@ 2012-03-26 15:20 ` Michal Privoznik
2012-03-26 17:07 ` Blue Swirl
1 sibling, 0 replies; 12+ messages in thread
From: Michal Privoznik @ 2012-03-26 15:20 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Brad Smith, Michael Roth, qemu-devel
On 26.03.2012 17:18, Anthony Liguori wrote:
> On 03/26/2012 10:15 AM, Michael Roth wrote:
>> On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote:
>>
>> Yup, I can't confirm the BSD fix atm though, only that it doesn't
>> break builds
>> on linux/w32. Send anyway or wait for confirmation?
>
> Brad/Michal,
>
> Can you confirm the fix?
I'd love to, but I don't have access to any *BSD machine right now.
Michal
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
2012-03-26 15:18 ` Anthony Liguori
2012-03-26 15:20 ` Michal Privoznik
@ 2012-03-26 17:07 ` Blue Swirl
1 sibling, 0 replies; 12+ messages in thread
From: Blue Swirl @ 2012-03-26 17:07 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Michal Privoznik, Brad Smith, Michael Roth, qemu-devel
On Mon, Mar 26, 2012 at 15:18, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 03/26/2012 10:15 AM, Michael Roth wrote:
>>
>> On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote:
>>
>> Yup, I can't confirm the BSD fix atm though, only that it doesn't break
>> builds
>> on linux/w32. Send anyway or wait for confirmation?
>
>
> Brad/Michal,
>
> Can you confirm the fix?
Fixes build.
Tested-by: Blue Swirl <blauwirbel@gmail.com>
> Regards,
>
> Anthony Liguori
>
>>
>>>
>>> Regards,
>>>
>>> Anthony Liguori
>>>
>>>>
>>>>>
>>>>> Michal
>>>>>
>>>>
>>>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-03-26 17:07 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-18 1:09 [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command Brad Smith
2012-03-20 10:14 ` Michal Privoznik
2012-03-20 13:28 ` Brad Smith
2012-03-25 1:19 ` Brad Smith
2012-03-25 19:47 ` Michael Roth
2012-03-26 9:28 ` Michal Privoznik
2012-03-26 14:53 ` Michael Roth
2012-03-26 14:55 ` Anthony Liguori
2012-03-26 15:15 ` Michael Roth
2012-03-26 15:18 ` Anthony Liguori
2012-03-26 15:20 ` Michal Privoznik
2012-03-26 17:07 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).