qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Brad Smith <brad@comstyle.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
Date: Tue, 20 Mar 2012 09:28:00 -0400	[thread overview]
Message-ID: <4F6885E0.1050708@comstyle.com> (raw)
In-Reply-To: <4F685882.2070105@redhat.com>

On 20/03/12 6:14 AM, Michal Privoznik wrote:
> On 18.03.2012 02:09, Brad Smith wrote:
>> Michal,
>>
>> http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
>>
>>
>> This broke the build. Un-break the tree.
>>
>
>
> Can you please be more specific? It works for me so I don't have a clue
> what are you referring to. I mean, what compiler do you use, what errors
> are thrown, etc.
>
> Michal

The patch commited is full of Linux specific code.

   CC    qga/commands-posix.o
In file included from qga/commands-posix.c:29:
/usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside 
parameter list
/usr/include/arpa/inet.h:74: warning: its scope is only this definition 
or declaration, which is probably not what you want
/usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside 
parameter list
qga/commands-posix.c: In function 'bios_supports_mode':
qga/commands-posix.c:587: error: 'environ' undeclared (first use in this 
function)
qga/commands-posix.c:587: error: (Each undeclared identifier is reported 
only once
qga/commands-posix.c:587: error: for each function it appears in.)
qga/commands-posix.c: In function 'guest_suspend':
qga/commands-posix.c:670: error: 'environ' undeclared (first use in this 
function)
qga/commands-posix.c: In function 'qmp_guest_network_get_interfaces':
qga/commands-posix.c:764: error: 'INET_ADDRSTRLEN' undeclared (first use 
in this function)
qga/commands-posix.c:765: error: 'INET6_ADDRSTRLEN' undeclared (first 
use in this function)
qga/commands-posix.c:789: error: 'SIOCGIFHWADDR' undeclared (first use 
in this function)
qga/commands-posix.c:810: error: 'struct ifreq' has no member named 
'ifr_hwaddr'
qga/commands-posix.c:832: error: dereferencing pointer to incomplete type
qga/commands-posix.c:846: error: dereferencing pointer to incomplete type
qga/commands-posix.c:854: error: dereferencing pointer to incomplete type
qga/commands-posix.c:868: error: dereferencing pointer to incomplete type
qga/commands-posix.c:765: warning: unused variable 'addr6'
qga/commands-posix.c:764: warning: unused variable 'addr4'
gmake: *** [qga/commands-posix.o] Error 1

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

  reply	other threads:[~2012-03-20 13:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-18  1:09 [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command Brad Smith
2012-03-20 10:14 ` Michal Privoznik
2012-03-20 13:28   ` Brad Smith [this message]
2012-03-25  1:19     ` Brad Smith
2012-03-25 19:47       ` Michael Roth
2012-03-26  9:28       ` Michal Privoznik
2012-03-26 14:53         ` Michael Roth
2012-03-26 14:55           ` Anthony Liguori
2012-03-26 15:15             ` Michael Roth
2012-03-26 15:18               ` Anthony Liguori
2012-03-26 15:20                 ` Michal Privoznik
2012-03-26 17:07                 ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6885E0.1050708@comstyle.com \
    --to=brad@comstyle.com \
    --cc=mprivozn@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).