From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA0OM-0002WZ-05 for qemu-devel@nongnu.org; Tue, 20 Mar 2012 10:50:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA0Nu-0003QQ-UJ for qemu-devel@nongnu.org; Tue, 20 Mar 2012 10:50:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA0Nu-0003Nj-Ms for qemu-devel@nongnu.org; Tue, 20 Mar 2012 10:50:02 -0400 Message-ID: <4F689912.7050605@redhat.com> Date: Tue, 20 Mar 2012 16:49:54 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20120319155650.GA6430@redhat.com> <4F6773B4.2040209@redhat.com> <20120319185723.GA8366@redhat.com> In-Reply-To: <20120319185723.GA8366@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Anthony Liguori , kvm@vger.kernel.org, Alexey Kardashevskiy , rusty@rustcorp.com.au, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org On 03/19/2012 08:57 PM, Michael S. Tsirkin wrote: > > > > Should be done via an extra BAR (with the same layout, perhaps extended) > > so compatibility is preserved. > > No, that would need guest changes to be of use. The point of this hack > is to make things work for Linux guests where PIO does not work. It only works if all guest's PCI layer knows to deal with the bit flip correctly. I imagine it isn't true for at least the seabios virtio drivers. -- error compiling committee.c: too many arguments to function