From: "Andreas Färber" <afaerber@suse.de>
To: Juan Quintela <quintela@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile
Date: Tue, 20 Mar 2012 16:41:35 +0100 [thread overview]
Message-ID: <4F68A52F.3070003@suse.de> (raw)
In-Reply-To: <1332257065-31184-1-git-send-email-quintela@redhat.com>
Am 20.03.2012 16:24, schrieb Juan Quintela:
> This change makes it compile and return the same value than the #undef one.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Cool,
Acked-by: Andreas Färber <afaerber@suse.de>
Tested the default, non-struct version only.
Juan, would it make sense to add a configure option for this #define,
similar to --enable-debug-tcg?
Andreas
> ---
> fpu/softfloat.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 81a7d1a..a1f4527 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -2219,7 +2219,7 @@ float32 float32_muladd(float32 a, float32 b, float32 c, int flags STATUS_PARAM)
> }
> }
> /* Zero plus something non-zero : just return the something */
> - return c ^ (signflip << 31);
> + return make_float32(float32_val(c) ^ (signflip << 31));
> }
>
> if (aExp == 0) {
> @@ -3772,7 +3772,7 @@ float64 float64_muladd(float64 a, float64 b, float64 c, int flags STATUS_PARAM)
> }
> }
> /* Zero plus something non-zero : just return the something */
> - return c ^ ((uint64_t)signflip << 63);
> + return make_float64(float64_val(c) ^ ((uint64_t)signflip << 63));
> }
>
> if (aExp == 0) {
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-20 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 15:24 [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile Juan Quintela
2012-03-20 15:36 ` Peter Maydell
2012-03-20 15:41 ` Andreas Färber [this message]
2012-03-20 15:49 ` Juan Quintela
2012-03-20 16:11 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F68A52F.3070003@suse.de \
--to=afaerber@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).