From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA1Bu-0006CI-Fm for qemu-devel@nongnu.org; Tue, 20 Mar 2012 11:41:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA1Bp-0005ZE-0P for qemu-devel@nongnu.org; Tue, 20 Mar 2012 11:41:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51860 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA1Bo-0005Z8-Qt for qemu-devel@nongnu.org; Tue, 20 Mar 2012 11:41:36 -0400 Message-ID: <4F68A52F.3070003@suse.de> Date: Tue, 20 Mar 2012 16:41:35 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1332257065-31184-1-git-send-email-quintela@redhat.com> In-Reply-To: <1332257065-31184-1-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org Am 20.03.2012 16:24, schrieb Juan Quintela: > This change makes it compile and return the same value than the #undef = one. >=20 > Signed-off-by: Juan Quintela Cool, Acked-by: Andreas F=E4rber Tested the default, non-struct version only. Juan, would it make sense to add a configure option for this #define, similar to --enable-debug-tcg? Andreas > --- > fpu/softfloat.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/fpu/softfloat.c b/fpu/softfloat.c > index 81a7d1a..a1f4527 100644 > --- a/fpu/softfloat.c > +++ b/fpu/softfloat.c > @@ -2219,7 +2219,7 @@ float32 float32_muladd(float32 a, float32 b, floa= t32 c, int flags STATUS_PARAM) > } > } > /* Zero plus something non-zero : just return the something */ > - return c ^ (signflip << 31); > + return make_float32(float32_val(c) ^ (signflip << 31)); > } >=20 > if (aExp =3D=3D 0) { > @@ -3772,7 +3772,7 @@ float64 float64_muladd(float64 a, float64 b, floa= t64 c, int flags STATUS_PARAM) > } > } > /* Zero plus something non-zero : just return the something */ > - return c ^ ((uint64_t)signflip << 63); > + return make_float64(float64_val(c) ^ ((uint64_t)signflip << 63= )); > } >=20 > if (aExp =3D=3D 0) { --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg