From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2M9-0006Yk-JQ for qemu-devel@nongnu.org; Tue, 20 Mar 2012 12:56:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SA2M3-0003Wg-BH for qemu-devel@nongnu.org; Tue, 20 Mar 2012 12:56:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SA2M3-0003WU-24 for qemu-devel@nongnu.org; Tue, 20 Mar 2012 12:56:15 -0400 Message-ID: <4F68AD69.8060500@redhat.com> Date: Tue, 20 Mar 2012 17:16:41 +0100 From: Michal Privoznik MIME-Version: 1.0 References: <0ccd5fa1764f254dbde6851c0d2139e9198a25e2.1332256180.git.mprivozn@redhat.com> <20120320161046.GA29058@illuin> In-Reply-To: <20120320161046.GA29058@illuin> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org On 20.03.2012 17:10, Michael Roth wrote: > On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote: >> Currently, the implementation of that command is full of >> Linux specific code. Before any brave man will step into >> and port it to other OSes, make this function Linux only. >> >> Signed-off-by: Michal Privoznik > > Which aspect is linux-specific? getifaddrs() and getnameinfo() seem to > be available on BSD and OpenSolaris, and we're already stubbed for w32. > Are you seeing breakage? Personally, I don't; but there has been this report: http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg03951.html which happens on OpenBSD, I suspect. Michal