From: "Crístian Viana" <vianac@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] Change timedrift default value to slew
Date: Tue, 20 Mar 2012 17:46:41 -0300 [thread overview]
Message-ID: <4F68ECB1.101@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F68E90E.6080601@us.ibm.com>
On 20-03-2012 17:31, Anthony Liguori wrote:
> On 03/20/2012 03:16 PM, Crístian Viana wrote:
>> On 20-03-2012 17:05, Anthony Liguori wrote:
>>> I think we just want to change:
>>>
>>> hw/mc146818rtc.h:
>>> DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
>>> lost_tick_policy, LOST_TICK_DISCARD),
>>>
>>> I think we just need to change this to LOST_TICK_SLEW. This would
>>> effectively change the default.
>>
>> I can't see this code snippet here, I guess we are in a different
>> branch. I'm using the current master branch (33cf629).
>
> http://git.qemu.org/?p=qemu.git;a=blob;f=hw/mc146818rtc.c;h=2b59c36ee66149f238ea415059c44d7d619925a6;hb=HEAD#l726
So that's on hw/mc146818rtc.c, not .h :-) Thanks for the suggestion,
I'll send a new patch now.
--
Best regards,
Crístian.
prev parent reply other threads:[~2012-03-20 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 19:48 [Qemu-devel] [PATCH 1/2] Force timedrift=none on previous machines Crístian Viana
2012-03-20 19:48 ` [Qemu-devel] [PATCH 2/2] Change timedrift default value to slew Crístian Viana
2012-03-20 20:05 ` Anthony Liguori
2012-03-20 20:16 ` Crístian Viana
2012-03-20 20:31 ` Anthony Liguori
2012-03-20 20:46 ` Crístian Viana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F68ECB1.101@linux.vnet.ibm.com \
--to=vianac@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).