From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vianac@linux.vnet.ibm.com>) id 1SA5xf-00051o-07
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 16:47:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vianac@linux.vnet.ibm.com>) id 1SA5xc-0002oU-O7
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 16:47:18 -0400
Received: from e24smtp05.br.ibm.com ([32.104.18.26]:35900)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vianac@linux.vnet.ibm.com>) id 1SA5xc-0002n2-Cr
	for qemu-devel@nongnu.org; Tue, 20 Mar 2012 16:47:16 -0400
Received: from /spool/local
	by e24smtp05.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <vianac@linux.vnet.ibm.com>;
	Tue, 20 Mar 2012 17:47:11 -0300
Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25])
	by d24dlp02.br.ibm.com (Postfix) with ESMTP id 645DD1DC004A
	for <qemu-devel@nongnu.org>; Tue, 20 Mar 2012 17:47:08 -0300 (BRT)
Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91])
	by d24relay03.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q2KKl1rt58982862
	for <qemu-devel@nongnu.org>; Tue, 20 Mar 2012 17:47:01 -0300
Received: from d24av01.br.ibm.com (loopback [127.0.0.1])
	by d24av01.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q2KIl2Tu017321
	for <qemu-devel@nongnu.org>; Tue, 20 Mar 2012 15:47:02 -0300
Message-ID: <4F68ECB1.101@linux.vnet.ibm.com>
Date: Tue, 20 Mar 2012 17:46:41 -0300
From: =?UTF-8?B?Q3LDrXN0aWFuIFZpYW5h?= <vianac@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1332272918-31746-1-git-send-email-vianac@linux.vnet.ibm.com>
	<1332272918-31746-2-git-send-email-vianac@linux.vnet.ibm.com>
	<4F68E2EC.9010309@us.ibm.com> <4F68E5BB.5060604@linux.vnet.ibm.com>
	<4F68E90E.6080601@us.ibm.com>
In-Reply-To: <4F68E90E.6080601@us.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 2/2] Change timedrift default value to slew
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org

On 20-03-2012 17:31, Anthony Liguori wrote:
> On 03/20/2012 03:16 PM, Crístian Viana wrote:
>> On 20-03-2012 17:05, Anthony Liguori wrote:
>>> I think we just want to change:
>>>
>>> hw/mc146818rtc.h:
>>>      DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
>>>                                 lost_tick_policy, LOST_TICK_DISCARD),
>>>
>>> I think we just need to change this to LOST_TICK_SLEW.  This would
>>> effectively change the default.
>>
>> I can't see this code snippet here, I guess we are in a different
>> branch. I'm using the current master branch (33cf629).
> 
> http://git.qemu.org/?p=qemu.git;a=blob;f=hw/mc146818rtc.c;h=2b59c36ee66149f238ea415059c44d7d619925a6;hb=HEAD#l726

So that's on hw/mc146818rtc.c, not .h :-) Thanks for the suggestion,
I'll send a new patch now.

-- 
Best regards,
Crístian.