From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support
Date: Wed, 21 Mar 2012 08:49:29 +0100 [thread overview]
Message-ID: <4F698809.1050202@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203201832460.15151@kaball-desktop>
Il 20/03/2012 19:35, Stefano Stabellini ha scritto:
> This is the function that is used to figure out whether we need the
> timers or not, the condition seems to be:
>
> (Not (REG_C_UF | REG_C_AF)) And (Not (REG_B_SET))
>
> Shouldn't actually check for UIE being enabled?
No, you need to set UF in case the code observes it without actually
enabling interrupt delivery on the ISA bus.
Paolo
next prev parent reply other threads:[~2012-03-21 7:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 6:14 [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support Zhang, Yang Z
2012-03-20 18:04 ` Stefano Stabellini
2012-03-20 18:35 ` Stefano Stabellini
2012-03-21 7:49 ` Paolo Bonzini [this message]
2012-03-21 16:54 ` Stefano Stabellini
2012-03-21 21:16 ` Paolo Bonzini
2012-03-22 10:29 ` Stefano Stabellini
2012-03-22 0:04 ` Zhang, Yang Z
2012-03-22 10:29 ` Stefano Stabellini
2012-03-22 10:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F698809.1050202@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).