From: Anthony Liguori <anthony@codemonkey.ws>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device
Date: Wed, 21 Mar 2012 11:33:21 -0500 [thread overview]
Message-ID: <4F6A02D1.9060404@codemonkey.ws> (raw)
In-Reply-To: <4F6A014A.90704@codemonkey.ws>
On 03/21/2012 11:26 AM, Anthony Liguori wrote:
> On 03/21/2012 11:11 AM, Michael S. Tsirkin wrote:
>> Frankly I don't see value in making it visible to the user,
>> at all. We are just triggering windows reactivations
>> without any user benefit. Why not return a fixed value there
>> to avoid that?
>
> I don't see a problem making it fixed for 1.1, but for 1.0 and older, we should
> expose what we were supposed to expose.
>
> We need to fix the bug first, then we can change the behavior.
In some cases, like USB, we really do want to expose a version, but we should
probably only expose the major version, for instance, QEMU 1.x or 2.x. This
would only be exposed by the appropriate machine types.
Regards,
Anthony Liguori
>
> Regards,
>
> Anthony Liguori
>
>>
>>>>>>
>>>>>>
>
>
next prev parent reply other threads:[~2012-03-21 16:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 4:59 [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device David Gibson
2012-03-19 11:33 ` Stefan Hajnoczi
2012-03-20 0:42 ` David Gibson
2012-03-20 9:54 ` Stefan Hajnoczi
2012-03-20 10:19 ` David Gibson
2012-03-21 11:26 ` Stefan Hajnoczi
2012-03-21 11:28 ` Stefan Hajnoczi
2012-03-21 13:24 ` David Gibson
2012-03-21 13:08 ` Michael S. Tsirkin
2012-03-21 14:42 ` Anthony Liguori
2012-03-21 15:10 ` Michael S. Tsirkin
2012-03-21 15:14 ` Anthony Liguori
2012-03-21 16:11 ` Michael S. Tsirkin
2012-03-21 16:26 ` Anthony Liguori
2012-03-21 16:33 ` Anthony Liguori [this message]
2012-03-21 18:28 ` Michael S. Tsirkin
2012-03-21 18:11 ` Michael S. Tsirkin
2012-03-20 10:53 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2012-03-26 1:19 David Gibson
2012-04-02 2:43 ` David Gibson
2012-04-02 6:46 ` Michael S. Tsirkin
2012-04-02 6:49 ` David Gibson
2012-04-02 7:11 ` Michael S. Tsirkin
2012-04-03 14:31 ` Michael S. Tsirkin
2012-03-22 9:09 David Gibson
2012-03-22 10:01 ` Stefan Hajnoczi
2012-03-22 10:27 ` Gerd Hoffmann
2012-03-22 10:32 ` Stefan Hajnoczi
2012-03-22 10:52 ` David Gibson
2012-03-22 11:53 ` Michael S. Tsirkin
2012-03-23 1:52 ` David Gibson
2012-03-23 12:54 ` Anthony Liguori
2012-03-16 1:03 David Gibson
2012-03-18 12:38 ` Michael S. Tsirkin
2012-03-19 2:17 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A02D1.9060404@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).