* [Qemu-devel] [PATCH v3 2/2] Change timedrift default value to slew
2012-03-21 16:06 [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines Crístian Viana
@ 2012-03-21 16:06 ` Crístian Viana
2012-03-21 21:37 ` Paolo Bonzini
2012-03-21 21:36 ` [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines Paolo Bonzini
2012-03-26 19:20 ` Anthony Liguori
2 siblings, 1 reply; 7+ messages in thread
From: Crístian Viana @ 2012-03-21 16:06 UTC (permalink / raw)
To: qemu-devel; +Cc: aliguori, Crístian Viana
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as
the time source. If time drift is not enabled, Windows is prone to
blue screening.
Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com>
---
hw/mc146818rtc.c | 2 +-
vl.c | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 2b59c36..2b31587 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -726,7 +726,7 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)
static Property mc146818rtc_properties[] = {
DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980),
DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
- lost_tick_policy, LOST_TICK_DISCARD),
+ lost_tick_policy, LOST_TICK_SLEW),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/vl.c b/vl.c
index 112b0e0..11817e5 100644
--- a/vl.c
+++ b/vl.c
@@ -539,18 +539,18 @@ static void configure_rtc(QemuOpts *opts)
value = qemu_opt_get(opts, "driftfix");
if (value) {
if (!strcmp(value, "slew")) {
- static GlobalProperty slew_lost_ticks[] = {
+ /* slew is default */
+ } else if (!strcmp(value, "none")) {
+ static GlobalProperty discard_lost_ticks[] = {
{
.driver = "mc146818rtc",
.property = "lost_tick_policy",
- .value = "slew",
+ .value = "discard",
},
{ /* end of list */ }
};
- qdev_prop_register_global_list(slew_lost_ticks);
- } else if (!strcmp(value, "none")) {
- /* discard is default */
+ qdev_prop_register_global_list(discard_lost_ticks);
} else {
fprintf(stderr, "qemu: invalid option value '%s'\n", value);
exit(1);
--
1.7.8.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH v3 2/2] Change timedrift default value to slew
2012-03-21 16:06 ` [Qemu-devel] [PATCH v3 2/2] Change timedrift default value to slew Crístian Viana
@ 2012-03-21 21:37 ` Paolo Bonzini
0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2012-03-21 21:37 UTC (permalink / raw)
To: Crístian Viana; +Cc: aliguori, qemu-devel
Il 21/03/2012 17:06, Crístian Viana ha scritto:
> Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as
> the time source. If time drift is not enabled, Windows is prone to
> blue screening.
>
> Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com>
> ---
> hw/mc146818rtc.c | 2 +-
> vl.c | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> index 2b59c36..2b31587 100644
> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -726,7 +726,7 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)
> static Property mc146818rtc_properties[] = {
> DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980),
> DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
> - lost_tick_policy, LOST_TICK_DISCARD),
> + lost_tick_policy, LOST_TICK_SLEW),
> DEFINE_PROP_END_OF_LIST(),
> };
>
> diff --git a/vl.c b/vl.c
> index 112b0e0..11817e5 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -539,18 +539,18 @@ static void configure_rtc(QemuOpts *opts)
> value = qemu_opt_get(opts, "driftfix");
> if (value) {
> if (!strcmp(value, "slew")) {
> - static GlobalProperty slew_lost_ticks[] = {
> + /* slew is default */
> + } else if (!strcmp(value, "none")) {
> + static GlobalProperty discard_lost_ticks[] = {
> {
> .driver = "mc146818rtc",
> .property = "lost_tick_policy",
> - .value = "slew",
> + .value = "discard",
> },
> { /* end of list */ }
> };
>
> - qdev_prop_register_global_list(slew_lost_ticks);
> - } else if (!strcmp(value, "none")) {
> - /* discard is default */
> + qdev_prop_register_global_list(discard_lost_ticks);
> } else {
> fprintf(stderr, "qemu: invalid option value '%s'\n", value);
> exit(1);
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines
2012-03-21 16:06 [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines Crístian Viana
2012-03-21 16:06 ` [Qemu-devel] [PATCH v3 2/2] Change timedrift default value to slew Crístian Viana
@ 2012-03-21 21:36 ` Paolo Bonzini
2012-03-22 10:37 ` Stefano Stabellini
2012-03-26 19:20 ` Anthony Liguori
2 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2012-03-21 21:36 UTC (permalink / raw)
To: Crístian Viana; +Cc: aliguori, qemu-devel, Stefano Stabellini
Il 21/03/2012 17:06, Crístian Viana ha scritto:
> The current value for the -rtc timedrift option is none. This patch
> makes sure that the old machines configuration will work the same way
> even after that option changes its default value.
>
> Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com>
> ---
> hw/pc_piix.c | 39 +++++++++++++++++++++++++++++++++++++++
> 1 files changed, 39 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 3f99f9a..08255b5 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -386,6 +386,10 @@ static QEMUMachine pc_machine_v1_0 = {
> .driver = "isa-fdc",
> .property = "check_media_rate",
> .value = "off",
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -405,6 +409,10 @@ static QEMUMachine pc_machine_v0_15 = {
> .driver = "isa-fdc",
> .property = "check_media_rate",
> .value = "off",
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -449,6 +457,10 @@ static QEMUMachine pc_machine_v0_14 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -505,6 +517,10 @@ static QEMUMachine pc_machine_v0_13 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -565,6 +581,10 @@ static QEMUMachine pc_machine_v0_12 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> }
> @@ -633,6 +653,10 @@ static QEMUMachine pc_machine_v0_11 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> }
> @@ -713,6 +737,10 @@ static QEMUMachine pc_machine_v0_10 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -728,6 +756,10 @@ static QEMUMachine isapc_machine = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -740,6 +772,13 @@ static QEMUMachine xenfv_machine = {
> .init = pc_xen_hvm_init,
> .max_cpus = HVM_MAX_VCPUS,
> .default_machine_opts = "accel=xen",
> + .compat_props = (GlobalProperty[]) {
> + {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> + },
> + { /* end of list */ }
> };
> #endif
>
Stefano, what do you want for Xen? Anyhow,
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines
2012-03-21 21:36 ` [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines Paolo Bonzini
@ 2012-03-22 10:37 ` Stefano Stabellini
2012-03-23 12:57 ` Anthony Liguori
0 siblings, 1 reply; 7+ messages in thread
From: Stefano Stabellini @ 2012-03-22 10:37 UTC (permalink / raw)
To: Paolo Bonzini
Cc: aliguori@us.ibm.com, Stefano Stabellini, Crístian Viana,
qemu-devel@nongnu.org
[-- Attachment #1: Type: text/plain, Size: 4413 bytes --]
On Wed, 21 Mar 2012, Paolo Bonzini wrote:
> Il 21/03/2012 17:06, Crístian Viana ha scritto:
> > The current value for the -rtc timedrift option is none. This patch
> > makes sure that the old machines configuration will work the same way
> > even after that option changes its default value.
> >
> > Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com>
> > ---
> > hw/pc_piix.c | 39 +++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 39 insertions(+), 0 deletions(-)
> >
> > diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> > index 3f99f9a..08255b5 100644
> > --- a/hw/pc_piix.c
> > +++ b/hw/pc_piix.c
> > @@ -386,6 +386,10 @@ static QEMUMachine pc_machine_v1_0 = {
> > .driver = "isa-fdc",
> > .property = "check_media_rate",
> > .value = "off",
> > + }, {
> > + .driver = "mc146818rtc",
> > + .property = "lost_tick_policy",
> > + .value = "none",
> > },
> > { /* end of list */ }
> > },
> > @@ -405,6 +409,10 @@ static QEMUMachine pc_machine_v0_15 = {
> > .driver = "isa-fdc",
> > .property = "check_media_rate",
> > .value = "off",
> > + }, {
> > + .driver = "mc146818rtc",
> > + .property = "lost_tick_policy",
> > + .value = "none",
> > },
> > { /* end of list */ }
> > },
> > @@ -449,6 +457,10 @@ static QEMUMachine pc_machine_v0_14 = {
> > .driver = "pc-sysfw",
> > .property = "rom_only",
> > .value = stringify(1),
> > + }, {
> > + .driver = "mc146818rtc",
> > + .property = "lost_tick_policy",
> > + .value = "none",
> > },
> > { /* end of list */ }
> > },
> > @@ -505,6 +517,10 @@ static QEMUMachine pc_machine_v0_13 = {
> > .driver = "pc-sysfw",
> > .property = "rom_only",
> > .value = stringify(1),
> > + }, {
> > + .driver = "mc146818rtc",
> > + .property = "lost_tick_policy",
> > + .value = "none",
> > },
> > { /* end of list */ }
> > },
> > @@ -565,6 +581,10 @@ static QEMUMachine pc_machine_v0_12 = {
> > .driver = "pc-sysfw",
> > .property = "rom_only",
> > .value = stringify(1),
> > + }, {
> > + .driver = "mc146818rtc",
> > + .property = "lost_tick_policy",
> > + .value = "none",
> > },
> > { /* end of list */ }
> > }
> > @@ -633,6 +653,10 @@ static QEMUMachine pc_machine_v0_11 = {
> > .driver = "pc-sysfw",
> > .property = "rom_only",
> > .value = stringify(1),
> > + }, {
> > + .driver = "mc146818rtc",
> > + .property = "lost_tick_policy",
> > + .value = "none",
> > },
> > { /* end of list */ }
> > }
> > @@ -713,6 +737,10 @@ static QEMUMachine pc_machine_v0_10 = {
> > .driver = "pc-sysfw",
> > .property = "rom_only",
> > .value = stringify(1),
> > + }, {
> > + .driver = "mc146818rtc",
> > + .property = "lost_tick_policy",
> > + .value = "none",
> > },
> > { /* end of list */ }
> > },
> > @@ -728,6 +756,10 @@ static QEMUMachine isapc_machine = {
> > .driver = "pc-sysfw",
> > .property = "rom_only",
> > .value = stringify(1),
> > + }, {
> > + .driver = "mc146818rtc",
> > + .property = "lost_tick_policy",
> > + .value = "none",
> > },
> > { /* end of list */ }
> > },
> > @@ -740,6 +772,13 @@ static QEMUMachine xenfv_machine = {
> > .init = pc_xen_hvm_init,
> > .max_cpus = HVM_MAX_VCPUS,
> > .default_machine_opts = "accel=xen",
> > + .compat_props = (GlobalProperty[]) {
> > + {
> > + .driver = "mc146818rtc",
> > + .property = "lost_tick_policy",
> > + .value = "none",
> > + },
> > + { /* end of list */ }
> > };
> > #endif
> >
>
> Stefano, what do you want for Xen? Anyhow,
I would like to keep the old policy for Xen, so the patch is fine by me.
Thanks for pinging me!
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines
2012-03-22 10:37 ` Stefano Stabellini
@ 2012-03-23 12:57 ` Anthony Liguori
0 siblings, 0 replies; 7+ messages in thread
From: Anthony Liguori @ 2012-03-23 12:57 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Paolo Bonzini, aliguori@us.ibm.com, Crístian Viana,
qemu-devel@nongnu.org
On 03/22/2012 05:37 AM, Stefano Stabellini wrote:
> On Wed, 21 Mar 2012, Paolo Bonzini wrote:
>> Il 21/03/2012 17:06, Crístian Viana ha scritto:
>>> @@ -740,6 +772,13 @@ static QEMUMachine xenfv_machine = {
>>> .init = pc_xen_hvm_init,
>>> .max_cpus = HVM_MAX_VCPUS,
>>> .default_machine_opts = "accel=xen",
>>> + .compat_props = (GlobalProperty[]) {
>>> + {
>>> + .driver = "mc146818rtc",
>>> + .property = "lost_tick_policy",
>>> + .value = "none",
>>> + },
>>> + { /* end of list */ }
>>> };
>>> #endif
>>>
>>
>> Stefano, what do you want for Xen? Anyhow,
>
> I would like to keep the old policy for Xen, so the patch is fine by me.
> Thanks for pinging me!
Xen emulates the RTC in the hypervisor, no? So it really wouldn't matter IIUC.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines
2012-03-21 16:06 [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines Crístian Viana
2012-03-21 16:06 ` [Qemu-devel] [PATCH v3 2/2] Change timedrift default value to slew Crístian Viana
2012-03-21 21:36 ` [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines Paolo Bonzini
@ 2012-03-26 19:20 ` Anthony Liguori
2 siblings, 0 replies; 7+ messages in thread
From: Anthony Liguori @ 2012-03-26 19:20 UTC (permalink / raw)
To: Crístian Viana; +Cc: qemu-devel
On 03/21/2012 11:06 AM, Crístian Viana wrote:
> The current value for the -rtc timedrift option is none. This patch
> makes sure that the old machines configuration will work the same way
> even after that option changes its default value.
>
> Signed-off-by: Crístian Viana<vianac@linux.vnet.ibm.com>
Something's off here:
Using machine: pc-0.14
/home/anthony/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel
bin/vmlinuz-3.0 -initrd .tmp-22118/initramfs-22118.img.gz -append console=ttyS0
seed=64521 -nographic -enable-kvm -hda .tmp-22118/disk-22118.img -M pc-0.14
-drive file=.tmp-22118/disk-22118.img,if=virtio,snapshot=on -device
virtio-balloon-pci -device virtio-serial -net nic,model=virtio -net user
-pidfile .tmp-22118/pidfile-22118.pid -qmp
unix:.tmp-22118/qmpsock-22118.sock,server,nowait
qemu-system-x86_64: Invalid parameter 'lost_tick_policy'
Regards,
Anthony Liguori
> ---
> hw/pc_piix.c | 39 +++++++++++++++++++++++++++++++++++++++
> 1 files changed, 39 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 3f99f9a..08255b5 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -386,6 +386,10 @@ static QEMUMachine pc_machine_v1_0 = {
> .driver = "isa-fdc",
> .property = "check_media_rate",
> .value = "off",
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -405,6 +409,10 @@ static QEMUMachine pc_machine_v0_15 = {
> .driver = "isa-fdc",
> .property = "check_media_rate",
> .value = "off",
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -449,6 +457,10 @@ static QEMUMachine pc_machine_v0_14 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -505,6 +517,10 @@ static QEMUMachine pc_machine_v0_13 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -565,6 +581,10 @@ static QEMUMachine pc_machine_v0_12 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> }
> @@ -633,6 +653,10 @@ static QEMUMachine pc_machine_v0_11 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> }
> @@ -713,6 +737,10 @@ static QEMUMachine pc_machine_v0_10 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -728,6 +756,10 @@ static QEMUMachine isapc_machine = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -740,6 +772,13 @@ static QEMUMachine xenfv_machine = {
> .init = pc_xen_hvm_init,
> .max_cpus = HVM_MAX_VCPUS,
> .default_machine_opts = "accel=xen",
> + .compat_props = (GlobalProperty[]) {
> + {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> + },
> + { /* end of list */ }
> };
> #endif
>
^ permalink raw reply [flat|nested] 7+ messages in thread