From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 3/3] configure: add --confsuffix option
Date: Wed, 21 Mar 2012 23:23:00 +0100 [thread overview]
Message-ID: <4F6A54C4.10800@redhat.com> (raw)
In-Reply-To: <20120321144220.GM9375@otherpad.lan.raisama.net>
Il 21/03/2012 15:42, Eduardo Habkost ha scritto:
> On Wed, Mar 21, 2012 at 01:39:39PM +0100, Paolo Bonzini wrote:
>> Il 20/03/2012 21:15, Eduardo Habkost ha scritto:
>>> This way we can choose a configuration file path different from
>>> ${sysconfdir}/PACKAGE.
>>>
>>> This also changes the configure output to show the full configuration
>>> dir path (including $confsuffix), instead of just $sysconfdir.
>>
>> Can you please apply this to datadir too? (i.e. set the datadir default
>> to just $prefix/share, and later add $confsuffix).
>
> I will do it, and send v3 of the series.
>
> I guess we don't want to change the meaning of
> './configure --datadir=PATH' (that currently expects the full path), to
> keep compatibility, right?
>
>
> To make sure the expected semantics are clear:
>
> This is straightforward:
>
> ./configure
> qemu data dir: /usr/share/qemu
> qemu conf dir: /etc/qemu
>
>
> For this one, we would have compatibility issues to take care of:
>
> ./configure --datadir=FOO --sysconfdir=SYS
> qemu data dir: FOO
> (it would be better if it was FOO/qemu, but needed for compatibility)
> qemu conf dir: SYS/qemu
Hmm, perhaps we can break it... I checked Fedora, Debian
(http://cdn.debian.net/debian/pool/main/q/qemu/qemu_1.0.1+dfsg-1.debian.tar.gz),
Arch Linux
(http://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/qemu),
Gentoo
(http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-emulation/qemu-kvm/qemu-kvm-0.15.1-r1.ebuild?view=markup),
FreeBSD
(http://www.freebsd.org/cgi/cvsweb.cgi/ports/emulators/qemu/Makefile?rev=1.122;content-type=text%2Fplain)
and none of them use it.
And since we are at it, let's call the option --with-confsuffix so it is
a bit more autoconfy.
Paolo
next prev parent reply other threads:[~2012-03-21 22:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 20:15 [Qemu-devel] [PATCH 0/3] add ./configure --confsuffix option (v2) Eduardo Habkost
2012-03-20 20:15 ` [Qemu-devel] [PATCH 1/3] Makefile: use $(confdir) instead of hardcoding $(sysconfdir)/qemu Eduardo Habkost
2012-03-21 12:40 ` Paolo Bonzini
2012-03-20 20:15 ` [Qemu-devel] [PATCH 2/3] qemu-options.hx: refer to confdir instead of sysconfdir on docs Eduardo Habkost
2012-03-21 12:43 ` Paolo Bonzini
2012-03-21 13:27 ` Eduardo Habkost
2012-03-20 20:15 ` [Qemu-devel] [PATCH 3/3] configure: add --confsuffix option Eduardo Habkost
2012-03-21 12:39 ` Paolo Bonzini
2012-03-21 14:42 ` Eduardo Habkost
2012-03-21 22:23 ` Paolo Bonzini [this message]
2012-03-22 12:54 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A54C4.10800@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).