From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44133)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SATvw-00056U-H5
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 18:23:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SATvt-0000Xe-DC
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 18:23:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57812)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SATvt-0000WI-5C
	for qemu-devel@nongnu.org; Wed, 21 Mar 2012 18:23:05 -0400
Message-ID: <4F6A54C4.10800@redhat.com>
Date: Wed, 21 Mar 2012 23:23:00 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1332274504-10437-1-git-send-email-ehabkost@redhat.com>
	<1332274504-10437-4-git-send-email-ehabkost@redhat.com>
	<4F69CC0B.1060906@redhat.com>
	<20120321144220.GM9375@otherpad.lan.raisama.net>
In-Reply-To: <20120321144220.GM9375@otherpad.lan.raisama.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] configure: add --confsuffix option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

Il 21/03/2012 15:42, Eduardo Habkost ha scritto:
> On Wed, Mar 21, 2012 at 01:39:39PM +0100, Paolo Bonzini wrote:
>> Il 20/03/2012 21:15, Eduardo Habkost ha scritto:
>>> This way we can choose a configuration file path different from
>>> ${sysconfdir}/PACKAGE.
>>>
>>> This also changes the configure output to show the full configuration
>>> dir path (including $confsuffix), instead of just $sysconfdir.
>>
>> Can you please apply this to datadir too?  (i.e. set the datadir default
>> to just $prefix/share, and later add $confsuffix).
> 
> I will do it, and send v3 of the series.
> 
> I guess we don't want to change the meaning of
> './configure --datadir=PATH' (that currently expects the full path), to
> keep compatibility, right?
> 
> 
> To make sure the expected semantics are clear:
> 
> This is straightforward:
> 
> ./configure
>   qemu data dir: /usr/share/qemu
>   qemu conf dir: /etc/qemu
> 
> 
> For this one, we would have compatibility issues to take care of:
> 
> ./configure --datadir=FOO --sysconfdir=SYS
>   qemu data dir: FOO
>     (it would be better if it was FOO/qemu, but needed for compatibility)
>   qemu conf dir: SYS/qemu

Hmm, perhaps we can break it...  I checked Fedora, Debian
(http://cdn.debian.net/debian/pool/main/q/qemu/qemu_1.0.1+dfsg-1.debian.tar.gz),
Arch Linux
(http://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/qemu),
Gentoo
(http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-emulation/qemu-kvm/qemu-kvm-0.15.1-r1.ebuild?view=markup),
FreeBSD
(http://www.freebsd.org/cgi/cvsweb.cgi/ports/emulators/qemu/Makefile?rev=1.122;content-type=text%2Fplain)
and none of them use it.

And since we are at it, let's call the option --with-confsuffix so it is
a bit more autoconfy.

Paolo