From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39936)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SAfFM-00007M-Pj
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 06:28:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SAfFF-0002gP-Kb
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 06:27:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12574)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1SAfFF-0002g7-Cr
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 06:27:49 -0400
Message-ID: <4F6AFE96.3050409@redhat.com>
Date: Thu, 22 Mar 2012 11:27:34 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1332407367-26551-1-git-send-email-david@gibson.dropbear.id.au>
	<CAJSP0QUCrdUsYP_r03jxsrqq0EeKAxH6cG+0+SxQAhwQMkhcTg@mail.gmail.com>
In-Reply-To: <CAJSP0QUCrdUsYP_r03jxsrqq0EeKAxH6cG+0+SxQAhwQMkhcTg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon
 device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: aliguori@us.ibm.com, Rusty Russell <rusty@rustcorp.com.au>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

>> +    if (proxy->class_code != PCI_CLASS_OTHERS &&
>> +        proxy->class_code != PCI_CLASS_MEMORY_RAM) /* qemu < 1.1 */
>> +        proxy->class_code = PCI_CLASS_OTHERS;
>> +
> 
> Why is this hunk is needed?

Catch users doing -device virtio-balloon,class=42

cheers,
  Gerd