From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32776)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1SAi4p-0000qI-BH
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 09:29:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1SAi4g-000147-TP
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 09:29:14 -0400
Received: from e39.co.us.ibm.com ([32.97.110.160]:35299)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1SAi4g-000138-MR
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 09:29:06 -0400
Received: from /spool/local
	by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Thu, 22 Mar 2012 07:29:01 -0600
Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id DDBD1C9006F
	for <qemu-devel@nongnu.org>; Thu, 22 Mar 2012 09:28:17 -0400 (EDT)
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q2MDSH1F272340
	for <qemu-devel@nongnu.org>; Thu, 22 Mar 2012 09:28:17 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q2MDSHd6015093
	for <qemu-devel@nongnu.org>; Thu, 22 Mar 2012 09:28:17 -0400
Received: from [9.59.241.154] (d941e-10.watson.ibm.com [9.59.241.154])
	by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id
	q2MDSGvO014959
	for <qemu-devel@nongnu.org>; Thu, 22 Mar 2012 09:28:16 -0400
Message-ID: <4F6B28F0.9060301@linux.vnet.ibm.com>
Date: Thu, 22 Mar 2012 09:28:16 -0400
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1332333220-31420-1-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1332333220-31420-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fix '-cpu ?' Segfault
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 03/21/2012 08:33 AM, Eduardo Habkost wrote:
> Fix stupid copy&paste mistake at commit
> ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept
> "optarg" on the cpu_list() call.
>
> Reported-by: Jiri Denemark<jdenemar@redhat.com>
> Signed-off-by: Eduardo Habkost<ehabkost@redhat.com>
> ---
>   vl.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 112b0e0..0fccf50 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3196,7 +3196,7 @@ int main(int argc, char **argv, char **envp)
>       cpudef_init();
>
>       if (cpu_model&&  *cpu_model == '?') {
> -        list_cpus(stdout,&fprintf, optarg);
> +        list_cpus(stdout,&fprintf, cpu_model);
>           exit(0);
>       }
>
Does -cpu ? actually work then? I only see the list of cpus when using 
-cpu ?_ for example.

    Stefan