From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAipp-0005J5-E2 for qemu-devel@nongnu.org; Thu, 22 Mar 2012 10:17:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAipj-0004pT-9a for qemu-devel@nongnu.org; Thu, 22 Mar 2012 10:17:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAipj-0004pK-1R for qemu-devel@nongnu.org; Thu, 22 Mar 2012 10:17:43 -0400 Message-ID: <4F6B3480.7010304@redhat.com> Date: Thu, 22 Mar 2012 15:17:36 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1332345124-381-1-git-send-email-benoit.canet@gmail.com> <1332345124-381-5-git-send-email-benoit.canet@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 4/7] qed: add bdrv_invalidate_cache to be called after incoming live migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, Stefan Hajnoczi , Anthony Liguori , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 22/03/2012 15:15, Beno=C3=AEt Canet ha scritto: >=20 > I added this flag after seeing the following code in in bdrv_open_commo= n. >=20 > /* > * Clear flags that are internal to the block layer before opening = the > * image. > */ > open_flags =3D flags & ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING); >=20 > This lead me to believe that bs->open_flags !=3D open_flags. Correct, see the first two patches in the series at http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg03467.html Paolo