From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58029)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SAjgg-0001rd-HI
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 11:12:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SAjgW-0000Dm-Cm
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 11:12:26 -0400
Received: from cantor2.suse.de ([195.135.220.15]:42359 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SAjgW-0000DO-6f
	for qemu-devel@nongnu.org; Thu, 22 Mar 2012 11:12:16 -0400
Message-ID: <4F6B414C.6070206@suse.de>
Date: Thu, 22 Mar 2012 16:12:12 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1332418064-23091-1-git-send-email-kraxel@redhat.com>
	<4F6B30A8.6060903@suse.de> <4F6B3933.20708@redhat.com>
In-Reply-To: <4F6B3933.20708@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Michael Roth <mdroth@linux.vnet.ibm.com>

Am 22.03.2012 15:37, schrieb Gerd Hoffmann:
>>> +            .driver   =3D "USB",
>>> +            .property =3D "full-path",
>>> +            .value    =3D "no",
>>
>> This touches on our "favorite" bit/bool topic again. While I agree tha=
t
>> "no" makes sense for a property of that name, the current code still
>> expects "on" and "off". In particular, "yes" would not work as expecte=
d.
>=20
> "no" *does* work as expected though, at least it survived my tests,
> thats why I didn't notice.
>=20
> I can s/no/off/ for consistency, no problem.  Merging your yes/no patch
> is fine with me too.

I stand corrected: Michael Roth's conversion of qdev properties to use
visitors implicitly changed the parsing logic to cover yes/no and
true/false as well. That's great news!

So no change of .value is needed here. The only thing to note is that
print_bit() will output the value as on/off.

Sorry for the confusion,

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg