From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAoRe-00078X-4f for qemu-devel@nongnu.org; Thu, 22 Mar 2012 16:17:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAoRc-0000cv-8N for qemu-devel@nongnu.org; Thu, 22 Mar 2012 16:17:13 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:47395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAoRc-0000cL-2B for qemu-devel@nongnu.org; Thu, 22 Mar 2012 16:17:12 -0400 Received: by pbcuo5 with SMTP id uo5so2214825pbc.4 for ; Thu, 22 Mar 2012 13:17:10 -0700 (PDT) Message-ID: <4F6B88BE.6040205@codemonkey.ws> Date: Thu, 22 Mar 2012 15:17:02 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332417072-20329-1-git-send-email-pbonzini@redhat.com> <1332417072-20329-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1332417072-20329-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] qapi: add a test case for type errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: anthony@codemonkey.vs, lcapitulino@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On 03/22/2012 06:51 AM, Paolo Bonzini wrote: > There is no test case for parse errors, add one. > > Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > test-qmp-input-visitor.c | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/test-qmp-input-visitor.c b/test-qmp-input-visitor.c > index 1996e49..c30fdc4 100644 > --- a/test-qmp-input-visitor.c > +++ b/test-qmp-input-visitor.c > @@ -258,6 +258,23 @@ static void input_visitor_test_add(const char *testpath, > visitor_input_teardown); > } > > +static void test_visitor_in_errors(TestInputVisitorData *data, > + const void *unused) > +{ > + TestStruct *p = NULL; > + Error *errp = NULL; > + Visitor *v; > + > + v = visitor_input_test_init(data, "{ 'integer': false, 'boolean': 'foo', 'string': -42 }"); > + > + visit_type_TestStruct(v,&p, NULL,&errp); > + g_assert(error_is_set(&errp)); > + g_assert(p->string == NULL); > + > + g_free(p->string); > + g_free(p); > +} > + > int main(int argc, char **argv) > { > TestInputVisitorData in_visitor_data; > @@ -282,6 +299,8 @@ int main(int argc, char **argv) > &in_visitor_data, test_visitor_in_list); > input_visitor_test_add("/visitor/input/union", > &in_visitor_data, test_visitor_in_union); > + input_visitor_test_add("/visitor/input/errors", > +&in_visitor_data, test_visitor_in_errors); > > g_test_run(); >