From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAobD-000745-Cx for qemu-devel@nongnu.org; Thu, 22 Mar 2012 16:27:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAobB-0002Xm-JT for qemu-devel@nongnu.org; Thu, 22 Mar 2012 16:27:06 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:45006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAobB-0002XW-DX for qemu-devel@nongnu.org; Thu, 22 Mar 2012 16:27:05 -0400 Received: by pbcuo5 with SMTP id uo5so2221979pbc.4 for ; Thu, 22 Mar 2012 13:27:03 -0700 (PDT) Message-ID: <4F6B8B14.9050303@codemonkey.ws> Date: Thu, 22 Mar 2012 15:27:00 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332417072-20329-1-git-send-email-pbonzini@redhat.com> <1332417072-20329-10-git-send-email-pbonzini@redhat.com> In-Reply-To: <1332417072-20329-10-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/10] qmp: add and use q type specifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: lcapitulino@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On 03/22/2012 06:51 AM, Paolo Bonzini wrote: > "O" is being used by the transaction and qom-set commands to mean "any > QObject", but it really means "do not validate the argument list". > Add a new specifier with the correct meaning. > > Signed-off-by: Paolo Bonzini Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > monitor.c | 3 +++ > qmp-commands.hx | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/monitor.c b/monitor.c > index 2ff1e0b..8946a10 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4157,6 +4157,9 @@ static int check_client_args_type(const QDict *client_args, > case 'O': > assert(flags& QMP_ACCEPT_UNKNOWNS); > break; > + case 'q': > + /* Any QObject can be passed. */ > + break; > case '/': > case '.': > /* > diff --git a/qmp-commands.hx b/qmp-commands.hx > index c626ba8..9447871 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -708,7 +708,7 @@ EQMP > }, > { > .name = "transaction", > - .args_type = "actions:O", > + .args_type = "actions:q", > .mhandler.cmd_new = qmp_marshal_input_transaction, > }, > > @@ -2125,7 +2125,7 @@ EQMP > > { > .name = "qom-set", > - .args_type = "path:s,property:s,opts:O", > + .args_type = "path:s,property:s,value:q", > .mhandler.cmd_new = qmp_qom_set, > }, >