From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB40e-0001iY-KL for qemu-devel@nongnu.org; Fri, 23 Mar 2012 08:54:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SB40d-0004JF-2Y for qemu-devel@nongnu.org; Fri, 23 Mar 2012 08:54:24 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:50274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB40c-0004In-U9 for qemu-devel@nongnu.org; Fri, 23 Mar 2012 08:54:22 -0400 Received: by obbwd20 with SMTP id wd20so2677736obb.4 for ; Fri, 23 Mar 2012 05:54:21 -0700 (PDT) Message-ID: <4F6C727A.2080301@codemonkey.ws> Date: Fri, 23 Mar 2012 07:54:18 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332407367-26551-1-git-send-email-david@gibson.dropbear.id.au> <20120322115332.GA13043@redhat.com> <20120323015213.GD9087@truffala.fritz.box> In-Reply-To: <20120323015213.GD9087@truffala.fritz.box> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , aliguori@us.ibm.com, qemu-devel@nongnu.org, Rusty Russell On 03/22/2012 08:52 PM, David Gibson wrote: > There is no fragment of code quite like the one you quote, only the > check for valid class values, which will accomplish the same thing. > It seemed clearer to have the default class value in the property > definition be, well, the default class value, rather than setting it > to 0 and having it overwritten. Agreed. Regards, Anthony Liguori >