From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB6w2-00013p-PX for qemu-devel@nongnu.org; Fri, 23 Mar 2012 12:01:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SB6vu-0002De-4C for qemu-devel@nongnu.org; Fri, 23 Mar 2012 12:01:50 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:51684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB6vt-0002DL-TQ for qemu-devel@nongnu.org; Fri, 23 Mar 2012 12:01:42 -0400 Received: by yhoo21 with SMTP id o21so3487796yho.4 for ; Fri, 23 Mar 2012 09:01:40 -0700 (PDT) Sender: Richard Henderson Message-ID: <4F6C9E60.9040803@twiddle.net> Date: Fri, 23 Mar 2012 09:01:36 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1332423372-2391-1-git-send-email-proljc@gmail.com> In-Reply-To: <1332423372-2391-1-git-send-email-proljc@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 0/4] MIPS ASE DSP Support for Qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jia Liu Cc: sw@weilnetz.de, qemu-devel@nongnu.org, aurelien@aurel32.net > +DEF_HELPER_1(absqsph, i32, i32) Many of these helpers merely compute a function. They do not trap, they do not modify global state. They should be using the DEF_HELPER_FLAGS_N macro to define them, so that the TCG compiler can optimize around the functions better. > target-mips/op_helper.c | 3936 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 3936 insertions(+), 0 deletions(-) Nearly 4000 lines to me says: put these in their own file. It would be my preference if this were done in a way that exposes any implicit uses of the ENV variable. But even failing that, the makefile can be adjusted to apply HELPER_CFLAGS to other helper files. r~