Re: [Qemu-devel] [PATCH 11/11 v10] introduce a new monitor command 'dump-guest-memory' to dump guest's memory

[Wen Congyang <wency@cn.fujitsu.com>]

At 03/24/2012 01:07 AM, Luiz Capitulino Wrote:
> On Fri, 23 Mar 2012 17:06:22 +0900 (   )
> HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:
> 
>> From: Wen Congyang <wency@cn.fujitsu.com>
>> Subject: [PATCH 11/11 v10] introduce a new monitor command 'dump-guest-memory' to dump guest's memory
>> Date: Tue, 20 Mar 2012 11:57:43 +0800
>>
>> <cut>
>>
>>> +typedef struct DumpState {
>>> +    ArchDumpInfo dump_info;
>>> +    MemoryMappingList list;
>>> +    uint16_t phdr_num;
>>> +    uint32_t sh_info;
>>> +    bool have_section;
>>> +    bool resume;
>>> +    target_phys_addr_t memory_offset;
>>> +    write_core_dump_function f;
>>
>> f() is so general. Type information is meaningless enough, but there's
>> no explicit occurence of the function call of f(). Could you consider
>> renaming?
> 
> Agreed. I actually don't see why this indirection is needed.
> 

Currently, we only support to write to fd. So this indirection isn't needed.
If we want to write the memory to other place, this indirection may be needed.
I will remove it as it isn't needed now. But the code in target-i386/arch_dump.c
will still use write_core_dump_function.

Thanks
Wen Congyang