From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SC9Eo-0004DW-Nd
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 08:41:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SC9Em-0007D5-VX
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 08:41:30 -0400
Received: from cantor2.suse.de ([195.135.220.15]:35106 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SC9Em-0007Ck-PK
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 08:41:28 -0400
Message-ID: <4F7063F3.4070906@suse.de>
Date: Mon, 26 Mar 2012 14:41:23 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1332763670-32063-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1332763670-32063-6-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1332763670-32063-6-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix broken build caused
 by wrong format specifier
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>, Anthony Liguori <aliguori@us.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Am 26.03.2012 14:07, schrieb Stefan Hajnoczi:
> From: Stefan Weil <sw@weilnetz.de>
>=20
> mem is an uint64_t value, so %lx was wrong.
>=20
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Alon, you replied with an "ACK". Should an Acked-by be inserted here?

Andreas

> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
>  trace-events |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/trace-events b/trace-events
> index 70f059d..db2cd39 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -726,7 +726,7 @@ ppm_save(const char *filename, void *display_surfac=
e) "%s surface=3D%p"
>  # hw/qxl.c
>  disable qxl_interface_set_mm_time(int qid, uint32_t mm_time) "%d %d"
>  disable qxl_io_write_vga(int qid, const char *mode, uint32_t addr, uin=
t32_t val) "%d %s addr=3D%u val=3D%u"
> -qxl_create_guest_primary(int qid, uint32_t width, uint32_t height, uin=
t64_t mem, uint32_t format, uint32_t position) "%d %dx%d mem=3D%lx %d,%d"
> +qxl_create_guest_primary(int qid, uint32_t width, uint32_t height, uin=
t64_t mem, uint32_t format, uint32_t position) "%d %ux%u mem=3D%" PRIx64 =
" %u,%u"
>  qxl_create_guest_primary_rest(int qid, int32_t stride, uint32_t type, =
uint32_t flags) "%d %d,%d,%d"
>  qxl_destroy_primary(int qid) "%d"
>  qxl_enter_vga_mode(int qid) "%d"

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg