From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38441)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SCBKN-0006JU-Vx
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 10:55:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SCBKL-0001Tq-WF
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 10:55:23 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:42640)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SCBKL-0001Th-Rd
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 10:55:21 -0400
Received: by ggnp2 with SMTP id p2so491883ggn.4
	for <qemu-devel@nongnu.org>; Mon, 26 Mar 2012 07:55:19 -0700 (PDT)
Message-ID: <4F708353.6020909@codemonkey.ws>
Date: Mon, 26 Mar 2012 09:55:15 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4F6535B5.4040405@comstyle.com> <4F685882.2070105@redhat.com>
	<4F6885E0.1050708@comstyle.com> <4F6E7298.5050601@comstyle.com>
	<4F7036A1.8070107@redhat.com> <20120326145327.GA2884@illuin>
In-Reply-To: <20120326145327.GA2884@illuin>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Build broken -- qemu-ga: add
 guest-network-get-interfaces command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: Michal Privoznik <mprivozn@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Brad Smith <brad@comstyle.com>

On 03/26/2012 09:53 AM, Michael Roth wrote:
> On Mon, Mar 26, 2012 at 11:28:01AM +0200, Michal Privoznik wrote:
>> On 25.03.2012 03:19, Brad Smith wrote:
>>> On 20/03/12 9:28 AM, Brad Smith wrote:
>>>> On 20/03/12 6:14 AM, Michal Privoznik wrote:
>>>>> On 18.03.2012 02:09, Brad Smith wrote:
>>>>>> Michal,
>>>>>>
>>>>>> http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> This broke the build. Un-break the tree.
>>>>>>
>>>>>
>>>>>
>>>>> Can you please be more specific? It works for me so I don't have a clue
>>>>> what are you referring to. I mean, what compiler do you use, what errors
>>>>> are thrown, etc.
>>>>>
>>>>> Michal
>>>>
>>>> The patch commited is full of Linux specific code.
>>>
>>> This is *STILL BROKEN*. If you can't get a fix in in a timely manner
>>> then REVERT
>>> the broken commit.
>>>
>>
>> Brad,
>>
>> that's because the fix hasn't been merged yet. If you need fix very
>> quickly you can apply this patch:
>>
>> http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg04054.html
>
> That one also requires your previous patch, and misses some things Luiz
> caught. This is the latest one, Brad is CC'd:
>
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg104240.html

Mike,

Can you send a PULL request?

Regards,

Anthony Liguori

>
>>
>> Michal
>>
>