From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCCpE-0006rU-Oe for qemu-devel@nongnu.org; Mon, 26 Mar 2012 12:31:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCCpA-0000NT-4l for qemu-devel@nongnu.org; Mon, 26 Mar 2012 12:31:20 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:53181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCCp9-0000ND-Uu for qemu-devel@nongnu.org; Mon, 26 Mar 2012 12:31:16 -0400 Received: by ghrr14 with SMTP id r14so4894307ghr.4 for ; Mon, 26 Mar 2012 09:31:14 -0700 (PDT) Sender: Richard Henderson Message-ID: <4F7099CD.90707@twiddle.net> Date: Mon, 26 Mar 2012 09:31:09 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1332714477-30079-1-git-send-email-rth@twiddle.net> <1332714477-30079-9-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/15] Avoid declaring the env variable at all if CONFIG_TCG_PASS_AREG0. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 03/26/12 09:26, Blue Swirl wrote: >> +#ifndef CONFIG_TCG_PASS_AREG0 >> env = env1; >> +#endif > > Shouldn't longjmp() restore global registers as well? Actually, we > return to cpu-exec.c which does not use global env. Isn't this > useless? Possibly. I didn't think to try to actually remove these uses, just get the code to compile without env being declared. > I'd change user-exec.c to work without global env use. I'll give it a shot... r~