From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54138)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SCDpQ-00087r-IR
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 13:35:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SCDpO-0003w3-L8
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 13:35:36 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:51429)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SCDpO-0003vf-Fu
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 13:35:34 -0400
Received: by yenr5 with SMTP id r5so4960320yen.4
	for <qemu-devel@nongnu.org>; Mon, 26 Mar 2012 10:35:33 -0700 (PDT)
Message-ID: <4F70A8E2.10508@codemonkey.ws>
Date: Mon, 26 Mar 2012 12:35:30 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1332727608-26523-1-git-send-email-liwp@linux.vnet.ibm.com>
	<CAAu8pHu_-btwffeytFFMQ-fogzqda2VO82GbqFS8VsnkZAJ1XA@mail.gmail.com>
In-Reply-To: <CAAu8pHu_-btwffeytFFMQ-fogzqda2VO82GbqFS8VsnkZAJ1XA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/6] refactor PC machine,
 i440fx and piix3 to take advantage of QOM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>, Wanpeng Li <liwp@linux.vnet.ibm.com>, Avi Kivity <avi@redhat.com>, Gavin Shan <shangw@linux.vnet.ibm.com>

On 03/26/2012 12:09 PM, Blue Swirl wrote:
> On Mon, Mar 26, 2012 at 02:06, Wanpeng Li<liwp@linux.vnet.ibm.com>  wrote:
>>
>> From: Anthony Liguori<aliguori@us.ibm.com>
>>
>>
>> This series aggressively refactors the PC machine initialization to be more
>> modelled and less ad-hoc.  The highlights of this series are:
>
> Please fix coding style while moving.

I disagree.  That makes reviewing the movement and rebasing the movement pretty 
difficult.

If we were to fix the issues, it should before or after.  But in that context, I 
think it makes it orthogonal to moving the code and should be treated independently.

Regards,

Anthony Liguori