From: Anthony Liguori <aliguori@us.ibm.com>
To: "Crístian Viana" <vianac@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines
Date: Mon, 26 Mar 2012 14:20:52 -0500 [thread overview]
Message-ID: <4F70C194.3060803@us.ibm.com> (raw)
In-Reply-To: <1332345997-4772-1-git-send-email-vianac@linux.vnet.ibm.com>
On 03/21/2012 11:06 AM, Crístian Viana wrote:
> The current value for the -rtc timedrift option is none. This patch
> makes sure that the old machines configuration will work the same way
> even after that option changes its default value.
>
> Signed-off-by: Crístian Viana<vianac@linux.vnet.ibm.com>
Something's off here:
Using machine: pc-0.14
/home/anthony/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel
bin/vmlinuz-3.0 -initrd .tmp-22118/initramfs-22118.img.gz -append console=ttyS0
seed=64521 -nographic -enable-kvm -hda .tmp-22118/disk-22118.img -M pc-0.14
-drive file=.tmp-22118/disk-22118.img,if=virtio,snapshot=on -device
virtio-balloon-pci -device virtio-serial -net nic,model=virtio -net user
-pidfile .tmp-22118/pidfile-22118.pid -qmp
unix:.tmp-22118/qmpsock-22118.sock,server,nowait
qemu-system-x86_64: Invalid parameter 'lost_tick_policy'
Regards,
Anthony Liguori
> ---
> hw/pc_piix.c | 39 +++++++++++++++++++++++++++++++++++++++
> 1 files changed, 39 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index 3f99f9a..08255b5 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -386,6 +386,10 @@ static QEMUMachine pc_machine_v1_0 = {
> .driver = "isa-fdc",
> .property = "check_media_rate",
> .value = "off",
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -405,6 +409,10 @@ static QEMUMachine pc_machine_v0_15 = {
> .driver = "isa-fdc",
> .property = "check_media_rate",
> .value = "off",
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -449,6 +457,10 @@ static QEMUMachine pc_machine_v0_14 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -505,6 +517,10 @@ static QEMUMachine pc_machine_v0_13 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -565,6 +581,10 @@ static QEMUMachine pc_machine_v0_12 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> }
> @@ -633,6 +653,10 @@ static QEMUMachine pc_machine_v0_11 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> }
> @@ -713,6 +737,10 @@ static QEMUMachine pc_machine_v0_10 = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -728,6 +756,10 @@ static QEMUMachine isapc_machine = {
> .driver = "pc-sysfw",
> .property = "rom_only",
> .value = stringify(1),
> + }, {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> },
> { /* end of list */ }
> },
> @@ -740,6 +772,13 @@ static QEMUMachine xenfv_machine = {
> .init = pc_xen_hvm_init,
> .max_cpus = HVM_MAX_VCPUS,
> .default_machine_opts = "accel=xen",
> + .compat_props = (GlobalProperty[]) {
> + {
> + .driver = "mc146818rtc",
> + .property = "lost_tick_policy",
> + .value = "none",
> + },
> + { /* end of list */ }
> };
> #endif
>
prev parent reply other threads:[~2012-03-26 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 16:06 [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines Crístian Viana
2012-03-21 16:06 ` [Qemu-devel] [PATCH v3 2/2] Change timedrift default value to slew Crístian Viana
2012-03-21 21:37 ` Paolo Bonzini
2012-03-21 21:36 ` [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines Paolo Bonzini
2012-03-22 10:37 ` Stefano Stabellini
2012-03-23 12:57 ` Anthony Liguori
2012-03-26 19:20 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F70C194.3060803@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=vianac@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).