From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCFTj-0000Af-2S for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:21:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCFTh-0006Hi-4R for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:21:18 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:39662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCFTh-0006Gq-0G for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:21:17 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 26 Mar 2012 15:21:12 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id B878738C8068 for ; Mon, 26 Mar 2012 15:21:09 -0400 (EDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2QJL7cZ343420 for ; Mon, 26 Mar 2012 15:21:08 -0400 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2QJKsC7031417 for ; Mon, 26 Mar 2012 13:20:56 -0600 Message-ID: <4F70C194.3060803@us.ibm.com> Date: Mon, 26 Mar 2012 14:20:52 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332345997-4772-1-git-send-email-vianac@linux.vnet.ibm.com> In-Reply-To: <1332345997-4772-1-git-send-email-vianac@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 1/2] Force timedrift=none on previous machines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?Q3LDrXN0aWFuIFZpYW5h?= Cc: qemu-devel@nongnu.org On 03/21/2012 11:06 AM, Crístian Viana wrote: > The current value for the -rtc timedrift option is none. This patch > makes sure that the old machines configuration will work the same way > even after that option changes its default value. > > Signed-off-by: Crístian Viana Something's off here: Using machine: pc-0.14 /home/anthony/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel bin/vmlinuz-3.0 -initrd .tmp-22118/initramfs-22118.img.gz -append console=ttyS0 seed=64521 -nographic -enable-kvm -hda .tmp-22118/disk-22118.img -M pc-0.14 -drive file=.tmp-22118/disk-22118.img,if=virtio,snapshot=on -device virtio-balloon-pci -device virtio-serial -net nic,model=virtio -net user -pidfile .tmp-22118/pidfile-22118.pid -qmp unix:.tmp-22118/qmpsock-22118.sock,server,nowait qemu-system-x86_64: Invalid parameter 'lost_tick_policy' Regards, Anthony Liguori > --- > hw/pc_piix.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 files changed, 39 insertions(+), 0 deletions(-) > > diff --git a/hw/pc_piix.c b/hw/pc_piix.c > index 3f99f9a..08255b5 100644 > --- a/hw/pc_piix.c > +++ b/hw/pc_piix.c > @@ -386,6 +386,10 @@ static QEMUMachine pc_machine_v1_0 = { > .driver = "isa-fdc", > .property = "check_media_rate", > .value = "off", > + }, { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "none", > }, > { /* end of list */ } > }, > @@ -405,6 +409,10 @@ static QEMUMachine pc_machine_v0_15 = { > .driver = "isa-fdc", > .property = "check_media_rate", > .value = "off", > + }, { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "none", > }, > { /* end of list */ } > }, > @@ -449,6 +457,10 @@ static QEMUMachine pc_machine_v0_14 = { > .driver = "pc-sysfw", > .property = "rom_only", > .value = stringify(1), > + }, { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "none", > }, > { /* end of list */ } > }, > @@ -505,6 +517,10 @@ static QEMUMachine pc_machine_v0_13 = { > .driver = "pc-sysfw", > .property = "rom_only", > .value = stringify(1), > + }, { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "none", > }, > { /* end of list */ } > }, > @@ -565,6 +581,10 @@ static QEMUMachine pc_machine_v0_12 = { > .driver = "pc-sysfw", > .property = "rom_only", > .value = stringify(1), > + }, { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "none", > }, > { /* end of list */ } > } > @@ -633,6 +653,10 @@ static QEMUMachine pc_machine_v0_11 = { > .driver = "pc-sysfw", > .property = "rom_only", > .value = stringify(1), > + }, { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "none", > }, > { /* end of list */ } > } > @@ -713,6 +737,10 @@ static QEMUMachine pc_machine_v0_10 = { > .driver = "pc-sysfw", > .property = "rom_only", > .value = stringify(1), > + }, { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "none", > }, > { /* end of list */ } > }, > @@ -728,6 +756,10 @@ static QEMUMachine isapc_machine = { > .driver = "pc-sysfw", > .property = "rom_only", > .value = stringify(1), > + }, { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "none", > }, > { /* end of list */ } > }, > @@ -740,6 +772,13 @@ static QEMUMachine xenfv_machine = { > .init = pc_xen_hvm_init, > .max_cpus = HVM_MAX_VCPUS, > .default_machine_opts = "accel=xen", > + .compat_props = (GlobalProperty[]) { > + { > + .driver = "mc146818rtc", > + .property = "lost_tick_policy", > + .value = "none", > + }, > + { /* end of list */ } > }; > #endif >