From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42028)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SCFlZ-0007rj-9M
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:39:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SCFlX-0003Qp-AU
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:39:44 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:53043)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1SCFlX-0003QY-5Q
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:39:43 -0400
Received: by obbwd20 with SMTP id wd20so6394857obb.4
	for <qemu-devel@nongnu.org>; Mon, 26 Mar 2012 12:39:41 -0700 (PDT)
Message-ID: <4F70C5FA.4060605@codemonkey.ws>
Date: Mon, 26 Mar 2012 14:39:38 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1332727608-26523-1-git-send-email-liwp@linux.vnet.ibm.com>
	<4F705F08.4010002@siemens.com> <4F70A877.3060809@codemonkey.ws>
	<4F70C3E0.4000708@web.de> <4F70C4F6.8090900@codemonkey.ws>
	<4F70C55D.4030203@web.de>
In-Reply-To: <4F70C55D.4030203@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/6] refactor PC machine,
 i440fx and piix3 to take advantage of QOM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Isaku Yamahata <yamahata@valinux.co.jp>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Wanpeng Li <liwp@linux.vnet.ibm.com>

On 03/26/2012 02:37 PM, Jan Kiszka wrote:
> On 2012-03-26 21:35, Anthony Liguori wrote:
>>>> Since this is an easily refactorable thing to look at later, I think
>>>> we should
>>>> start with extracting the types.
>>>
>>> My worry is that those three refactorings set bad examples for others.
>>> So I'd like to avoid such back and forth if possible.
>>
>> I'm not really worried about it.  It's so easier to refactor this
>> later.  Why rush it now?
>
> You rush changing the current layout, not me. :)

No, I'm trying to do incremental changes without boiling the ocean in the process.

I think we all are in violent agreement about where we want to end up (as opaque 
types as possible).  I don't want to hold back additional refactoring on doing 
this right (and it's not just a matter of malloc/free).

Regards,

Anthony Liguori

> Jan
>