qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, stefanha@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] test: remove qemu-ga reference
Date: Mon, 26 Mar 2012 15:07:09 -0500	[thread overview]
Message-ID: <4F70CC6D.9050404@codemonkey.ws> (raw)
In-Reply-To: <1332342646-9250-1-git-send-email-mdroth@linux.vnet.ibm.com>

On 03/21/2012 10:10 AM, Michael Roth wrote:
> This was added by mistake a while back.
>
> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   Makefile       |    1 +
>   tests/Makefile |    2 +-
>   2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 1bc3cb0..cab7c74 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -173,6 +173,7 @@ qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
>   $(qapi-obj-y): $(GENERATED_HEADERS)
>   qapi-dir := $(BUILD_DIR)/qapi-generated
>   qemu-ga$(EXESUF): LIBS = $(LIBS_QGA)
> +qemu-ga$(EXESUF): QEMU_CFLAGS += -I $(qapi-dir)
>
>   gen-out-type = $(subst .,-,$(suffix $@))
>
> diff --git a/tests/Makefile b/tests/Makefile
> index c78ade1..354fdbb 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -17,7 +17,7 @@ test-coroutine: test-coroutine.o qemu-timer-common.o async.o $(coroutine-obj-y)
>
>   test-qmp-input-visitor.o test-qmp-output-visitor.o \
>   test-string-input-visitor.o test-string-output-visitor.o \
> -	test-qmp-commands.o qemu-ga$(EXESUF): QEMU_CFLAGS += -I $(qapi-dir)
> +	test-qmp-commands.o: QEMU_CFLAGS += -I $(qapi-dir)
>
>   $(qapi-dir)/test-qapi-types.c $(qapi-dir)/test-qapi-types.h :\
>   $(SRC_PATH)/qapi-schema-test.json $(SRC_PATH)/scripts/qapi-types.py

      parent reply	other threads:[~2012-03-26 20:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20  0:18 [Qemu-devel] [PATCH 1/3] test: remove qemu-ga reference Michael Roth
2012-03-20  0:18 ` [Qemu-devel] [PATCH 2/3] qapi: remove print statements from test-qmp-commands Michael Roth
2012-03-20  0:18 ` [Qemu-devel] [PATCH 3/3] test: add test-qmp-commands to make check Michael Roth
2012-03-21 11:37 ` [Qemu-devel] [PATCH 1/3] test: remove qemu-ga reference Stefan Hajnoczi
2012-03-21 15:06   ` Michael Roth
2012-03-21 15:10 ` [Qemu-devel] [PATCH v2] " Michael Roth
2012-03-22  8:14   ` Stefan Hajnoczi
2012-03-26 20:07   ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F70CC6D.9050404@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).