From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Wanpeng Li <liwp@linux.vnet.ibm.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Isaku Yamahata <yamahata@valinux.co.jp>,
Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>,
Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM
Date: Mon, 26 Mar 2012 15:13:08 -0500 [thread overview]
Message-ID: <4F70CDD4.2090903@codemonkey.ws> (raw)
In-Reply-To: <4F70CD2A.3040802@web.de>
On 03/26/2012 03:10 PM, Jan Kiszka wrote:
> On 2012-03-26 21:49, Anthony Liguori wrote:
>> On 03/26/2012 02:44 PM, Jan Kiszka wrote:
>> This would also mean that reference counting should be revisited
>> although with how dereferencing a parent affects the child.
>>
>> It's not rocket science, but it's also something that needs to be done
>> carefully.
>
> But all this is only a problem for these three here (PIT, RTC, HPET) as
> their objects shall be embedded into the super-IO. If you only embed an
> object pointer, it shouldn't be an issue anymore, no?
The reference counting stuff obviously needs to be looked at even in this case.
> Also inheritance is not a problem here as we do not derive from the
> three types in question. If there is a super/sub-class relation, those
> need to share an internal header, of course.
Yes, but then you have two headers for every type. Is that really a good thing?
I think I prefer to just mark fields as /*< private >*/ and scold people if they
violate that convention.
Regards,
Anthony Liguori
>
> Jan
next prev parent reply other threads:[~2012-03-26 20:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 2:06 [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM Wanpeng Li
2012-03-26 2:06 ` [Qemu-devel] [PATCH 1/6] eliminate piix_pci.c and module i440fx and piix3 Wanpeng Li
2012-03-26 2:06 ` [Qemu-devel] [PATCH 2/6] convert MemoryRegion to QOM Wanpeng Li
2012-03-26 2:06 ` [Qemu-devel] [PATCH 3/6] convert pci-host " Wanpeng Li
2012-03-26 7:32 ` Stefan Hajnoczi
2012-03-26 9:22 ` Wanpeng Li
2012-03-26 14:25 ` Andreas Färber
2012-03-26 2:06 ` [Qemu-devel] [PATCH 4/6] prepare to create HPET, RTC and i8254 through composition Wanpeng Li
2012-03-26 2:06 ` [Qemu-devel] [PATCH 5/6] merge pc_piix.c to pc.c Wanpeng Li
2012-03-26 12:42 ` Avi Kivity
2012-03-26 12:47 ` Jan Kiszka
2012-03-26 17:37 ` Anthony Liguori
2012-03-26 2:06 ` [Qemu-devel] [PATCH 6/6] make some functions static Wanpeng Li
2012-03-26 12:20 ` [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM Jan Kiszka
2012-03-26 15:54 ` Isaku Yamahata
2012-03-26 17:29 ` Anthony Liguori
2012-03-27 10:31 ` Avi Kivity
2012-03-27 13:52 ` Anthony Liguori
2012-03-27 14:18 ` Avi Kivity
2012-03-26 17:17 ` Blue Swirl
2012-03-26 17:33 ` Anthony Liguori
2012-03-26 19:30 ` Jan Kiszka
2012-03-26 19:35 ` Anthony Liguori
2012-03-26 19:37 ` Jan Kiszka
2012-03-26 19:39 ` Anthony Liguori
2012-03-26 19:44 ` Jan Kiszka
2012-03-26 19:49 ` Anthony Liguori
2012-03-26 20:10 ` Jan Kiszka
2012-03-26 20:13 ` Anthony Liguori [this message]
2012-03-26 20:30 ` Jan Kiszka
2012-03-26 21:00 ` Anthony Liguori
2012-03-26 19:52 ` Anthony Liguori
2012-03-26 12:47 ` Andreas Färber
2012-03-26 12:57 ` Wanpeng Li
2012-03-26 17:09 ` Blue Swirl
2012-03-26 17:35 ` Anthony Liguori
2012-03-26 17:43 ` Blue Swirl
2012-03-26 17:45 ` Anthony Liguori
2012-03-26 18:01 ` Blue Swirl
2012-03-26 18:07 ` Anthony Liguori
2012-03-26 18:25 ` Blue Swirl
2012-03-26 17:25 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F70CDD4.2090903@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=liwp@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shangw@linux.vnet.ibm.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).