From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCUsD-0006Yc-OM for qemu-devel@nongnu.org; Tue, 27 Mar 2012 07:47:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCUsB-0006ve-Qo for qemu-devel@nongnu.org; Tue, 27 Mar 2012 07:47:37 -0400 Received: from thoth.sbs.de ([192.35.17.2]:25952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCUsB-0006vJ-HC for qemu-devel@nongnu.org; Tue, 27 Mar 2012 07:47:35 -0400 Message-ID: <4F71A8D0.8050301@siemens.com> Date: Tue, 27 Mar 2012 13:47:28 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1332606390-3605-1-git-send-email-lee.essen@nowonline.co.uk> <1332606390-3605-2-git-send-email-lee.essen@nowonline.co.uk> <4F71A75E.4050104@suse.de> <4F71A867.7030206@siemens.com> In-Reply-To: <4F71A867.7030206@siemens.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/4] Enable sigbus_reraise for Solaris List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Lee Essen , Blue Swirl , qemu-devel@nongnu.org, Stefan Hajnoczi On 2012-03-27 13:45, Jan Kiszka wrote: > On 2012-03-27 13:41, Andreas F=E4rber wrote: >> Am 24.03.2012 17:26, schrieb Lee Essen: >>> sigbus_reraise is used by the kvm_wait_io_event function and is >>> needed on both Linux and Solaris. This patch adds CONFIG_SOLARIS >>> to the current CONFIG_LINUX only ifdef. >>> >>> Signed-off-by: Lee Essen >>> --- >>> cpus.c | 4 +++- >>> 1 files changed, 3 insertions(+), 1 deletions(-) >>> >>> diff --git a/cpus.c b/cpus.c >>> index 25ba621..6550f22 100644 >>> --- a/cpus.c >>> +++ b/cpus.c >>> @@ -455,7 +455,7 @@ static void cpu_signal(int sig) >>> exit_request =3D 1; >>> } >>> =20 >>> -#ifdef CONFIG_LINUX >>> +#if defined(CONFIG_LINUX) || defined(CONFIG_SOLARIS) >> >> As asked elsewhere: Linux was the only KVM platform so far. If >=20 > Power, s390, soon also ARM? Err, forget about this part. :) > Also, this code is not KVM specific, MCE > forwarding is supposed to work with TCG as well. >=20 > That said, some generic HAVE_MCE_FORWARDING or so makes probably sense > when there are more platform supporting it. >=20 > Jan >=20 >> sigbus_reraise() is only used in some KVM function like you said, can'= t >> this we guarded with #if defined(CONFIG_KVM) or similar so that we don= 't >> have to expand this once FreeBSD etc. merge KVM support, i.e. feature-= based? >> >> Andreas >> >>> static void sigbus_reraise(void) >>> { >>> sigset_t set; >>> @@ -491,7 +491,9 @@ static void qemu_init_sigbus(void) >>> action.sa_sigaction =3D (void (*)(int, siginfo_t*, void*))sigbus= _handler; >>> sigaction(SIGBUS, &action, NULL); >>> =20 >>> +#if defined(CONFIG_LINUX) >>> prctl(PR_MCE_KILL, PR_MCE_KILL_SET, PR_MCE_KILL_EARLY, 0, 0); >>> +#endif >>> } >>> =20 >>> static void qemu_kvm_eat_signals(CPUArchState *env) >> >=20 --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux